[PATCH 2/8] Makefile.in: introduce -Wunused-function

Ian Jackson ijackson at chiark.greenend.org.uk
Wed May 14 21:00:22 BST 2014


And delete the two unused logging functions log_multi and syslog_log.

Signed-off-by: Ian Jackson <ijackson at chiark.greenend.org.uk>
---
 Makefile.in |    2 +-
 log.c       |   22 ----------------------
 2 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 0680512..64b6158 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -36,7 +36,7 @@ CFLAGS:=-Wall @WRITESTRINGS@ @CFLAGS@ -Werror \
 	-Wno-pointer-sign -Wstrict-prototypes -Wmissing-prototypes \
 	-Wmissing-declarations -Wnested-externs -Wredundant-decls \
 	-Wpointer-arith -Wformat=2 -Winit-self \
-	-Wswitch-enum -Wunused-variable -Wbad-function-cast \
+	-Wswitch-enum -Wunused-variable -Wunused-function -Wbad-function-cast \
 	-Wno-strict-aliasing -fno-strict-aliasing
 ALL_CFLAGS:=@DEFS@ -I$(srcdir) -I. $(CFLAGS) $(EXTRA_CFLAGS)
 CPPFLAGS:=@CPPFLAGS@ $(EXTRA_CPPFLAGS)
diff --git a/log.c b/log.c
index 4aa12e7..326a891 100644
--- a/log.c
+++ b/log.c
@@ -189,17 +189,6 @@ static void log_vmulti(void *sst, int class, const char *message, va_list args)
     }
 }
 
-static void log_multi(void *st, int priority, const char *message, ...)
-    FORMAT(printf,3,4);
-static void log_multi(void *st, int priority, const char *message, ...)
-{
-    va_list ap;
-
-    va_start(ap,message);
-    log_vmulti(st,priority,message,ap);
-    va_end(ap);
-}
-
 struct log_if *init_log(list_t *ll)
 {
     int i=0;
@@ -409,17 +398,6 @@ static void syslog_vlog(void *sst, int class, const char *message,
     }
 }
 
-static void syslog_log(void *sst, int priority, const char *message, ...)
-    FORMAT(printf,3,4);
-static void syslog_log(void *sst, int priority, const char *message, ...)
-{
-    va_list ap;
-
-    va_start(ap,message);
-    syslog_vlog(sst,priority,message,ap);
-    va_end(ap);
-}
-
 static struct flagstr syslog_facility_table[]={
 #ifdef LOG_AUTH
     { "auth", LOG_AUTH },
-- 
1.7.10.4




More information about the sgo-software-discuss mailing list