[PATCH 06/25] NOTES: Remove paragraph about slow-to-prepare messages

Ian Jackson ijackson at chiark.greenend.org.uk
Sat Jul 20 00:38:50 BST 2013


NOTES contained this paragraph:

  Some messages may take a long time to prepare (software modexp on slow
  machines); this is a "please wait" message to indicate that a message
  is in preparation.

This paragraph was immediately after the description of the msg0(msg9)
packet - ie, the ordinary data packet.  It is therefore at the very
least misplaced.

In the git history this paragraph was introduced in "Import release
0.1.14" (4f5e39ec).  However, the diff for that commit (ie the diff
between 0.1.13 and 0.1.4) does not show any code which might
correspond to this comment.

There is not currently any code in site.c which responds to a message
of this kind.  I have had a quick look for code which sends such a
message and failed to find any.

So I think this paragraph represents a never-implemented intent, and
should be removed.  It certainly predates the "hacky parallelism" by a
long way.

Signed-off-by: Ian Jackson <ijackson at chiark.greenend.org.uk>
---
 NOTES |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/NOTES b/NOTES
index 6a245ec..09c083e 100644
--- a/NOTES
+++ b/NOTES
@@ -251,10 +251,6 @@ some reason.
 
 8) i?,i?,msg0,(send-packet/msg9,packet)_k
 
-Some messages may take a long time to prepare (software modexp on slow
-machines); this is a "please wait" message to indicate that a message
-is in preparation.
-
 **** Other messages
 
 9) i?,i?,NAK (NAK is encoded as zero)
-- 
1.7.2.5




More information about the sgo-software-discuss mailing list