[PATCH 3/3] New --managed option for use when running under a daemon supervisor.

Richard Kettlewell rjk at terraraq.org.uk
Sat Dec 10 17:08:29 GMT 2011


On 04/08/2011 15:23, Ian Jackson wrote:
> Richard Kettlewell writes ("[PATCH 3/3] New --managed option for use when running under a daemon supervisor."):
>> -    if (secnet_is_daemon) {
>> +    if (secnet_is_daemon&&  system_log) {
>
> This is an unrelated bugfix, isn't it ?

It was arguably a conceptual confusion that secnet_is_daemon is 
conflated with system_log having been created, but in the code as it 
previously stood the sequencing meant that secnet_is_daemon!=0 implied 
system_log has been created, so it would never go wrong in practice.  I 
don't believe it makes sense to break it out into a separate commit.

Actually I think it should simply be:

   if(system_log)

ttfn/rjk



More information about the sgo-software-discuss mailing list