[PATCH 2/2] sys_cmd error handling improved in the following ways: (1) If the subprocess exits nonzero then the exit status is unpicked and logged. (2) If the exec in the child fails, the command and errno string are written to stderr (which should end up in secnet's usual log output). (3) _exit() is used instead of exit(), to avoid any possibility of craziness with stdio/atexit/etc.

[Ian Jackson]

Richard Kettlewell writes ("Re: [PATCH 2/2] sys_cmd error handling improved in the following ways: (1) If the subprocess exits nonzero then the exit status is unpicked and logged. (2) If the exec in the child fails, the command and errno string are written to stderr (which should end up in secnet's usual log output). (3) _exit() is used instead of exit(), to avoid any possibility of craziness with stdio/atexit/etc."):
> I'm not sure what git-send-email was playing at there.  The description 
> in a more readable form:

The first line of the commit message is supposed to be a short summary
(often called the "subject" as it goes into email subjects), and it's
conventional to leave a blank line after it.  I think
git-format-patch/git-send-email probably think the whole first
"paragraph" is supposed to be the "subject".

If you leavve a blank line it will do the right thing.

>      sys_cmd error handling improved in the following ways:
>      (1) If the subprocess exits nonzero then the exit status
>          is unpicked and logged.

Although for this commit message
  "sys_cmd error handling improved in the following ways:"
isn't really a self-contained subject/summary.  I would say

]      sys_cmd error handling improved
]
]      (1) If the subprocess exits nonzero then the exit status
]          is unpicked and logged.
]      (2) etc.

Ian.