[PATCH 1/4] resolver: support IPv4 address literals

Richard Kettlewell rjk at terraraq.org.uk
Sat Jul 9 10:37:35 BST 2011


On 05/07/2011 12:10, Ian Jackson wrote:
> Signed-off-by: Ian Jackson<ijackson at chiark.greenend.org.uk>
> ---
>   resolver.c |   16 ++++++++++++++++
>   1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/resolver.c b/resolver.c
> index f60b112..f4eeee6 100644
> --- a/resolver.c
> +++ b/resolver.c
> @@ -6,6 +6,8 @@
>   #error secnet requires ADNS version 1.0 or above
>   #endif
>   #include<adns.h>
> +#include<arpa/inet.h>
> +#include<string.h>
>
>
>   struct adns {
> @@ -28,6 +30,20 @@ static bool_t resolve_request(void *sst, cstring_t name,
>       struct adns *st=sst;
>       struct query *q;
>       int rv;
> +    const int maxlitlen=50;
> +
> +    int l=strlen(name);

Oh, I missed this earlier.  Will overflow if supplied with a 
ridiculously long string (e.g. on a 64-bit platform).  Probably not a 
big deal, but...

ttfn/rjk





More information about the sgo-software-discuss mailing list