Bug#851427: sysvinit makes /dev/shm a symlink to /run/shm, should be other way round

[Dolphin Oracle]

Thank you.  I will make sure to use a patch in the future.


On Jan 12, 2019 7:41 AM, "Dmitry Bogatov" <KAction at debian.org> wrote:


[ Please, next time attach patch, not whole file. Much more convenient
  for review ]

[2019-01-10 10:54] Dolphin Oracle <dolphinoracle at gmail.com>

> the buster version of sysvinit initscripts still mounts the with /run/shm
> as the mount point for the tmpfs and /dev/shm as a symlink.
>
> just adding on to the discussion...the situation actually prevents running
> certain flatpak applications.
>
> modifying mount-functions.sh per the attached will reverse the situation,

Works fine to me, I intend to accept it. Dear co-maintainers,
any objections?


> although there is still some migration code in there that strictly
speaking
> isn't necessary.

Further patches are welcome. Just remember, that not only fresh installs
must work fine, but also upgrade from stable must be smooth and painless.

Here is patch for convenience of other developers:

diff --git a/debian/src/initscripts/lib/init/mount-functions.sh
b/debian/src/initscripts/lib/init/mount-functions.sh
index 7511761c..98f53a86 100644
--- a/debian/src/initscripts/lib/init/mount-functions.sh
+++ b/debian/src/initscripts/lib/init/mount-functions.sh
@@ -436,7 +436,7 @@ post_mountall ()
        # directory.  The migration logic will then take care of the
        # rest.  Note that it will take a second boot to fully
        # migrate; it should only ever be needed on broken systems.
-       RAMSHM_ON_DEV_SHM="no"
+       RAMSHM_ON_DEV_SHM="yes"
        if read_fstab_entry "/dev/shm"; then
            RAMSHM_ON_DEV_SHM="yes"
        fi
@@ -559,8 +559,8 @@ mount_shm ()
 {
        MNTMODE="$1"

-       RAMSHM_ON_DEV_SHM="no"
-       SHMDIR="/run/shm"
+       RAMSHM_ON_DEV_SHM="yes"
+       SHMDIR="/dev/shm"
        if read_fstab_entry "/dev/shm"; then
                if [ "$MNTMODE" = "mount_noupdate" ]; then
                        log_warning_msg "Warning: fstab entry for /dev/shm;
should probably be for /run/shm unless working around a bug in the Oracle
database"
@@ -706,13 +706,3 @@ is_fastboot_active() {
        done
        return 1
 }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.chiark.greenend.org.uk/pipermail/debian-init-diversity/attachments/20190112/85ea32f6/attachment.html>