routetrade: Fix suppresed trades: suppress by removing from @subflows

diff --git a/yarrg/web/routetrade b/yarrg/web/routetrade
index 5dc5e774a40f8c839a26ef28c75d8c6b9bc7b31a..09e908b1ac44e160fb817dacb612a8c746e19b67 100644 (file)
--- a/yarrg/web/routetrade
+++ b/yarrg/web/routetrade
@@ -292,22 +292,6 @@ foreach my $f (@flows) {
                $f->{"Max$v"}= sprintf "%.1f", $f->{"Max${v}SortKey"} * 1e-6;
        }
 
-       my $sfis= $ipair2subflowinfs{$f->{'org_id'},$f->{'dst_id'}};
-       foreach my $sfi (@$sfis) {
-               my $subflow= {
-                       Flow => $f,
-                       Org => $sfi->[0],
-                       Dst => $sfi->[1],
-                       Var => sprintf "f%ss%s_c%d_p%d_%d_p%d_%d",
-                               $f->{Ix}, $sfi->[0],
-                               $f->{'commodid'},
-                               $sfi->[0], $f->{'org_price'},
-                               $sfi->[1], $f->{'dst_price'}
-               };
-               push @{ $f->{Subflows} }, $subflow;
-               push @subflows, $subflow;
-       }
-
        $f->{MarginSortKey}= sprintf "%d",
                $f->{'dst_price'} * 10000 / $f->{'org_price'};
        $f->{Margin}= sprintf "%3.1f%%",
@@ -385,8 +369,23 @@ foreach my $f (@flows) {
        if (defined $qa->{"R$f->{UidShort}"} &&
            !defined $qa->{"T$f->{UidShort}"}) {
                $f->{Suppress}= 1;
+       } else {
+               my $sfis= $ipair2subflowinfs{$f->{'org_id'},$f->{'dst_id'}};
+               foreach my $sfi (@$sfis) {
+                       my $subflow= {
+                               Flow => $f,
+                               Org => $sfi->[0],
+                               Dst => $sfi->[1],
+                               Var => sprintf "f%ss%s_c%d_p%d_%d_p%d_%d",
+                                       $f->{Ix}, $sfi->[0],
+                                       $f->{'commodid'},
+                                       $sfi->[0], $f->{'org_price'},
+                                       $sfi->[1], $f->{'dst_price'}
+                       };
+                       push @{ $f->{Subflows} }, $subflow;
+                       push @subflows, $subflow;
+               }
        }
-
 }
 </%perl>
 
@@ -421,13 +420,7 @@ Subject To
 
 my %avail_lims;
 foreach my $flow (@flows) {
-       if ($flow->{Suppress}) {
-               foreach my $sf (@{ $flow->{Subflows} }) {
-                       $cplex .= "
-   $sf->{Var} = 0\n";
-               }
-               next;
-       }
+       next if $flow->{Suppress};
        foreach my $od (qw(org dst)) {
                my $limname= join '_', (
                        $od,
@@ -671,7 +664,6 @@ Generated by YARRG at <strong><%
        #print " [[ i $i od $od " if $qa->{'debug'};
        foreach my $sf (@subflows) {
                my $f= $sf->{Flow};
-               next if $f->{Suppress};
                next unless $sf->{ucfirst $od} == $i;
                #print " FLOW $f->{Ix} SUB #$sf->{Org}..$sf->{Dst} "
                #       if $qa->{'debug'};