From 87f7f25f01e3c0af51cce64fb7f93dd7b0d0861a Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 16 Jun 2009 15:57:49 +0100 Subject: [PATCH] WIP MIT-SHM; seems to do SHM but need to check performance --- pctb/pages.c | 149 ++++++++++++++++++++++++++++++++++----------------- pctb/x.gdb | 5 +- 2 files changed, 101 insertions(+), 53 deletions(-) diff --git a/pctb/pages.c b/pctb/pages.c index 56fb409..cdf7c05 100644 --- a/pctb/pages.c +++ b/pctb/pages.c @@ -77,7 +77,7 @@ void screenshot_startup(void) { /*---------- pager ----------*/ -typedef XImage Snapshot; +typedef RgbImage Snapshot; static double last_input; static const double min_update_allowance= 0.25; @@ -200,36 +200,102 @@ static void send_pgdown_torestore(void) { } static void free_snapshot(Snapshot **io) { - if (*io) XDestroyImage(*io); + free(*io); *io= 0; } +#define SAMPLEMASK 0xfful + +typedef struct { + int lshift, rshift; +} ShMask; + +static void compute_shift_mask(ShMask *sm, unsigned long ximage_mask) { + sm->lshift= 0; + sm->rshift= 0; + + for (;;) { + if (ximage_mask <= (SAMPLEMASK>>1)) { + sm->lshift++; ximage_mask <<= 1; + } else if (ximage_mask > SAMPLEMASK) { + sm->rshift++; ximage_mask >>= 1; + } else { + break; + } + assert(!(sm->lshift && sm->rshift)); + } + assert(sm->lshift < LONG_BIT); + assert(sm->rshift < LONG_BIT); +} + +static void rtimestamp(double *t) { + double n= timestamp(); + debugf("PAGING INTERVAL %f\n", n-*t); + *t= n; +} + static void snapshot(Snapshot **output) { - free_snapshot(output); + XImage *im_use, *im_free=0; + + ShMask shiftmasks[3]; debugf("PAGING snapshot\n"); - timestamp(); - *output= XGetImage(disp,id, 0,0, wwidth,wheight, AllPlanes, ZPixmap); - timestamp(); + double begin= timestamp(); + if (shmim) { + im_use= shmim; + xassert( XShmGetImage(disp,id,shmim, 0,0, AllPlanes) ); + } else { + xassert( im_use= im_free= + XGetImage(disp,id, 0,0, wwidth,wheight, AllPlanes, ZPixmap) ); + } + rtimestamp(&begin); +#define COMPUTE_SHIFT_MASK(ix, rgb) \ + compute_shift_mask(&shiftmasks[ix], im_use->rgb##_mask) + COMPUTE_SHIFT_MASK(0, red); + COMPUTE_SHIFT_MASK(1, green); + COMPUTE_SHIFT_MASK(2, blue); + + if (!*output) + *output= alloc_rgb_image(wwidth, wheight); + + rtimestamp(&begin); + + int x,y,i; + unsigned char *op= (*output)->data; + for (y=0; y> shiftmasks[i].rshift) + & SAMPLEMASK; + *op++= sample; + } + } + } + + rtimestamp(&begin); + if (im_free) + XDestroyImage(im_free); + + rtimestamp(&begin); check_not_disturbed(); debugf("PAGING snapshot done.\n"); } static int identical(const Snapshot *a, const Snapshot *b) { - if (!(a->width == b->width && - a->height == b->height && - a->bytes_per_line == b->bytes_per_line && - a->format == b->format)) + if (!(a->w == b->w && + a->h == b->h)) return 0; - int compare_to= a->height; + int compare_to= a->h; if (max_relevant_y && compare_to > max_relevant_y) compare_to= max_relevant_y; - return !memcmp(a->data, b->data, a->bytes_per_line * compare_to); + return !memcmp(a->data, b->data, a->w * 3 * compare_to); } static void wait_for_stability(Snapshot **output, @@ -330,6 +396,7 @@ static void raise_and_get_details(void) { check_client_window_all_on_screen(); int shm= XShmQueryExtension(disp); + // shm=0; if (shm) { xassert( shmim= XShmCreateImage(disp, attr.visual, attr.depth, ZPixmap, 0,&shminfo, wwidth,wheight) ); @@ -405,54 +472,20 @@ static void set_focus_commodity(void) { debugf("PAGING raise_and_set_focus done.\n"); } -#define SAMPLEMASK 0xfful - -typedef struct { - int lshift, rshift; -} ShMask; - -static void compute_shift_mask(ShMask *sm, unsigned long ximage_mask) { - sm->lshift= 0; - sm->rshift= 0; - - for (;;) { - if (ximage_mask <= (SAMPLEMASK>>1)) { - sm->lshift++; ximage_mask <<= 1; - } else if (ximage_mask > SAMPLEMASK) { - sm->rshift++; ximage_mask >>= 1; - } else { - break; - } - assert(!(sm->lshift && sm->rshift)); - } - assert(sm->lshift < LONG_BIT); - assert(sm->rshift < LONG_BIT); -} - static CanonImage *convert_page(Snapshot *sn, RgbImage *ri) { - ShMask shiftmasks[3]; CanonImage *im; fprintf(screenshot_file, "P6\n" "%d %d\n" - "255\n", sn->width, sn->height); - -#define COMPUTE_SHIFT_MASK(ix, rgb) \ - compute_shift_mask(&shiftmasks[ix], sn->rgb##_mask) - COMPUTE_SHIFT_MASK(0, red); - COMPUTE_SHIFT_MASK(1, green); - COMPUTE_SHIFT_MASK(2, blue); + "255\n", sn->w, sn->h); - CANONICALISE_IMAGE(im, sn->width, sn->height, { - long xrgb= XGetPixel(sn, x, y); + CANONICALISE_IMAGE(im, sn->w, sn->h, { int i; rgb= 0; for (i=0; i<3; i++) { rgb <<= 8; - unsigned long sample= - ((xrgb << shiftmasks[i].lshift) - >> shiftmasks[i].rshift) & SAMPLEMASK; + unsigned long sample= RI_PIXEL(sn,x,y)[i]; rgb |= sample; fputc(sample, screenshot_file); } @@ -473,6 +506,22 @@ static void prepare_ypp_client(void) { /* find the window and check it's on the right kind of screen */ raise_and_get_details(); wait_for_stability(¤t,0,0, "checking current YPP client screen..."); + +#if 1 +timestamp(); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +snapshot(¤t); +timestamp(); +#endif + test= convert_page(current, 0); find_structure(test, &max_relevant_y); check_correct_commodities(); @@ -539,7 +588,7 @@ void take_one_screenshot(void) { prepare_ypp_client(); wait_for_stability(¤t,0,0, "taking screenshot..."); - page0_rgbimage= alloc_rgb_image(current->width, current->height); + page0_rgbimage= alloc_rgb_image(current->w, current->h); page_images[0]= convert_page(current, 0); npages= 1; progress_log("collected single screenshot."); diff --git a/pctb/x.gdb b/pctb/x.gdb index 477c23d..1484ddb 100644 --- a/pctb/x.gdb +++ b/pctb/x.gdb @@ -1,6 +1,5 @@ file ypp-commodities set confirm off -set args -Drect --same --arbitrage -#watch o_screenshots_fn -#break convert.c:125 +set args -Dpages --window-id 0x1c228b9 +break pages.c:267 run -- 2.30.2