X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~yarrgweb/git?p=ypp-sc-tools.db-test.git;a=blobdiff_plain;f=yarrg%2FCommods.pm;h=91781126d319a32c5f0a5d15f3ec499c82af1fbb;hp=5161af2e8a05a121ca690d41662ebd9012bb8c63;hb=363f7060f6fd6ffceca3611b7283c695cc2731df;hpb=e85ef56a3b2eff647efc77e44ba5ba0a19e53393

diff --git a/yarrg/Commods.pm b/yarrg/Commods.pm
index 5161af2..9178112 100644
--- a/yarrg/Commods.pm
+++ b/yarrg/Commods.pm
@@ -37,10 +37,10 @@ BEGIN {
     @ISA         = qw(Exporter);
     @EXPORT      = qw(&parse_info_clientside &fetch_with_rsync
 		      &parse_info_serverside &parse_info_serverside_ocean
-		      %oceans %commods %clients
+		      %oceans %commods %clients %commodclasses
 		      %vessels %shotname2damage
 		      &parse_pctb_commodmap %pctb_commodmap @pctb_commodmap
-		      &get_our_version &check_tsv_line
+		      &get_our_version &check_tsv_line &errsan
 		      &pipethrough_prep &pipethrough_run
 		      &pipethrough_run_along &pipethrough_run_finish
 		      &pipethrough_run_gzip &http_useragent &version_core
@@ -102,7 +102,7 @@ my %colours; # eg $colours{'c'}{'black'}= $sources
 my (@rawcm, @nocm); # eg $rawcm[0]='fine rum'; $rawcm[1]='fine %c cloth'
 
 my %colour_ordvals; # $colour_ordvals{'c'}{'green'}= '30';
-my %commodclasses; # $commodclasses{'dye'}= '3';
+our %commodclasses; # $commodclasses{'dye'}= '3';
 
 # IMPORTANT
 #  when extending the format of source-info in a non-backward
@@ -137,7 +137,7 @@ sub parse_info1 ($$$) {
 	    @ctx= (sub { push @nocm, lc $_; });
 	} elsif (m/^commodclasses$/) {
 	    @ctx= (sub {
-		die unless m/^\*([-a-z]+)$/;
+		die unless m/^\*([_a-z]+)$/;
 		$commodclasses{$1}= scalar keys %commodclasses;
 	    });
 	} elsif (m/^ocean (\w+)$/) {
@@ -213,7 +213,7 @@ sub parse_info1 ($$$) {
 		    $c->{Mass}= $1 * ($2 ? 1000 : 1);
 		} elsif ($prop =~ m/^([1-9]\d*)l$/) {
 		    $c->{Volume}= $1 * 1000;
-		} elsif ($prop =~ m/^\*([-a-z]+)$/) {
+		} elsif ($prop =~ m/^\*([_a-z]+)$/) {
 		    $c->{Class}= $1;
 		    die "$1" unless exists $commodclasses{$1};
 		    $ordclassval= 1e7 + $commodclasses{$1} * 1e7;
@@ -224,6 +224,7 @@ sub parse_info1 ($$$) {
 		    die "unknown property $prop for $ucname";
 		}
 	    }
+	    $c->{ClassOrdval}= $ordclassval;
 	    if (defined $ordbase && defined $ordval && defined $ordclassval) {
 		my $ordvalout= $ordbase + $ordval + $ordclassval;
 		$c->{Ordval}= $ordvalout;
@@ -406,6 +407,12 @@ sub cgipostform ($$$) {
 
 our %check_tsv_done;
 
+sub errsan ($) {
+    my ($value) = @_;
+    $value =~ s/[^-+\'. A-Za-z0-9]/ sprintf "\\x%02x",ord $& /ge;
+    return "\"$value\"";
+}
+
 sub check_tsv_line ($$) {
     my ($l, $bad_data_callback) = @_;
     my $bad_data= sub { &$bad_data_callback("bad data: line $.: $_[0]"); };
@@ -419,15 +426,19 @@ sub check_tsv_line ($$) {
 
     !keys %commods or
 	defined $commods{$commod} or
-	&$bad_data("unknown commodity \`$commod'");
+	&$bad_data("unknown commodity ".errsan($commod));
     
-    $stall =~ m/^\p{IsUpper}|^[0-9]/ or &$bad_data("stall not capitalised");
-    !exists $check_tsv_done{$commod,$stall} or &$bad_data("repeated data");
+    $stall =~ m/^\p{IsUpper}|^[0-9]/ or
+	&$bad_data("stall not capitalised ".errsan($stall));
+    !exists $check_tsv_done{$commod,$stall} or
+	&$bad_data("repeated data ".errsan($commod).",".errsan($stall));
     $check_tsv_done{$commod,$stall}= 1;
     foreach my $i (2..5) {
 	my $f= $v[$i];
-	$f =~ m/^(|0|[1-9][0-9]{0,5}|\>1000)$/ or &$bad_data("bad field $i");
-	($i % 2) or ($f !~ m/\>/) or &$bad_data("> in field $i price");
+	$f =~ m/^(|0|[1-9][0-9]{0,5}|\>1000)$/ or
+	    &$bad_data("bad field $i ".errsan($f));
+	($i % 2) or ($f !~ m/\>/) or
+	    &$bad_data("> in field $i price ".errsan($f));
     }
 
     foreach my $i (2,4) {