X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~yarrgweb/git?p=ypp-sc-tools.db-live.git;a=blobdiff_plain;f=yarrg%2Fweb%2Froutetrade;h=97359a9fc1fea4920f7a6deaad345d775a34d036;hp=6bc7277d341a69049358dbb40176700657674187;hb=cfb91181c6dec6df662af8325c0293d4c2e8be25;hpb=f41b94c1ec31bbff084b7429c1aec495aca2ab1e

diff --git a/yarrg/web/routetrade b/yarrg/web/routetrade
index 6bc7277..97359a9 100644
--- a/yarrg/web/routetrade
+++ b/yarrg/web/routetrade
@@ -32,6 +32,42 @@
  This Mason component is the core trade planner for a specific route.
 
 
+========== TODO ==========
+16:36 <ceb> alpha,byrne,papaya,turtle,jorvik,luthien is my example
+
+16:37 <ceb> if tehre are 2 rows which take the same object and sell it for the 
+            same profit at two other islands, choose the shortest route as the 
+            preferred one
+16:37 <ceb> coconut buy 10 sell 16, at luthien or jorvik, in that example
+16:38 <ceb> Do you see what I mean?
+
+16:38 <ceb> I don't know how hard this is, but can you show only the suggested 
+            trades to start ith and have a button to show all?
+16:39 <ceb> Also, maybe colour to highlight the suggested trades?
+
+16:40 <ceb> columns should be sortable with the small arrows as before
+
+16:51 <ceb> YPP interfaces have price then qty. You have qty then price. This 
+            is confusing!
+16:51 <ceb> the max column ordering is OK
+16:51 <ceb> (alo profit and suggested are OK)
+16:52 <Diziet> Err, you want qty on the left in those two but on the right in 
+               collect and deliver ?
+16:53 <ceb> Yes (price and capital are not the same thing)
+16:53 <Diziet> OK
+16:53 <ceb> for max the order in which you want to think about it is 'I need to 
+            buy ten of them and that will cost me $total price)
+16:54 <ceb> s/)/'/
+
+16:46 <ceb> Also trading plan not functional but I guess you know that :-)
+
+Also:
+- potential cost of losses
+- max volume/mass
+- use POST for update.  Hrrm.
+
+========== TODO ==========
+
 </%doc>
 <%args>
 $dbh
@@ -260,7 +296,8 @@ die "$cmpu $uue ?" if length $cmpu > 20;
 			die "$f->{UidLong} = $f->{UidShort} = $recons_long ?";
 	}
 
-	if ($qa->{"R$f->{UidShort}"} && !$qa->{"T$f->{UidShort}"}) {
+	if (defined $qa->{"R$f->{UidShort}"} &&
+	    !defined $qa->{"T$f->{UidShort}"}) {
 		$f->{Suppress}= 1;
 	}