X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~yarrgweb/git?a=blobdiff_plain;f=yarrg%2FCommodsWeb.pm;h=84ea71066c186902d95b7108e874323092ff8d0b;hb=492ee8e5d023945e2768e9568f22bd63a19b59f4;hp=f0c183ce0872adb68b31a1d80b5f3849659a9b3e;hpb=d1140fe21c4a6cdb1ba9c02e26b80d71ffe31965;p=ypp-sc-tools.main.git

diff --git a/yarrg/CommodsWeb.pm b/yarrg/CommodsWeb.pm
index f0c183c..84ea710 100644
--- a/yarrg/CommodsWeb.pm
+++ b/yarrg/CommodsWeb.pm
@@ -43,15 +43,12 @@ use JSON;
 use Commods;
 use CommodsDatabase;
 
-our $self_url;
-our $base_url;
-
 BEGIN {
     use Exporter ();
     our ($VERSION, @ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
     $VERSION     = 1.00;
     @ISA         = qw(Exporter);
-    @EXPORT      = qw(&dbw_connect &ocean_list $sourcebasedir
+    @EXPORT      = qw(&dbw_connect &ocean_list &sourcebasedir
 		      &to_json_shim &to_json_protecttags
 		      &set_ctype_utf8
 		      &prettyprint_age &meta_prettyprint_age);
@@ -60,24 +57,31 @@ BEGIN {
     @EXPORT_OK   = qw();
 }
 
-our $datadir='.';
-our $sourcebasedir;
-
-for my $dir (@INC) {
-    if ($dir =~ m/\.perl-lib$/) {
-	$sourcebasedir= "$dir/..";
-	if (stat "$dir/DATA") {
-	    $datadir= "$dir/DATA";
-	} elsif ($!==&ENOENT) {
-	    $datadir= "$dir";
-	} else {
-	    die "stat $dir/DATA $!";
+sub sourcebasedir () {
+    my $dir;
+    
+    for my $dir (@INC) {
+	if ($dir =~ m/\.perl-lib$/) {
+	    $dir= "$dir/..";
+	    last;
 	}
-	last;
     }
+    defined $dir or
+	die "no source base dir in @INC";
+    return $dir;
+}
+
+my datadir () {
+    my $dir= sourcebasedir();
+    if (stat "$dir/DATA") {
+	return "$dir/DATA";
+    } elsif ($!==&ENOENT) {
+	return "$dir";
+    } else {
+	die "stat $dir/DATA $!";
+    }
+    return '.';
 }
-defined $sourcebasedir or
-    die "no source base dir in @INC";
 
 my @ocean_list;
 
@@ -101,7 +105,7 @@ sub dbw_connect ($) {
     my ($ocean) = @_;
     die "unknown ocean $ocean ?"
 	unless grep { $_ eq $ocean } ocean_list();
-    return dbr_connect($datadir, $ocean);
+    return dbr_connect(datadir(), $ocean);
 }
 
 sub to_json_shim ($) {
@@ -134,7 +138,7 @@ END
 };
 
 BEGIN { eval '
-  sub prettyprint_age (\$) {
+  sub prettyprint_age ($) {
 		my ($age) = @_;
 		'.meta_prettyprint_age('$age','floor','.').'
   };