chiark / gitweb /
proper error reporting of post requests incl. to yarrg
[jarrg-ian.git] / src / com / tedpearson / ypp / market / MarketUploader.java
index 715e847b895eac70e691b0fce699ea256b01edc0..666ad23f844e01f1478453db2db2d3e2836fdbd5 100644 (file)
@@ -16,7 +16,7 @@ import org.w3c.dom.*;
 import javax.xml.parsers.DocumentBuilderFactory;
 import org.xml.sax.InputSource;
 import java.util.zip.GZIPOutputStream;
-import com.myjavatools.web.ClientHttpRequest;
+import net.chiark.yarrg.ClientHttpRequest;
 import java.util.regex.*;
 import java.util.prefs.Preferences;
 import java.beans.*;
@@ -340,6 +340,25 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                JOptionPane.showMessageDialog(frame,msg,"Error",JOptionPane.ERROR_MESSAGE);
        }
        
+       private void error_html(String msg, String html) {
+               //System.err.println("===" + html + "===");
+
+               Pattern body = Pattern.compile("<body>(.*)</body>", Pattern.DOTALL | Pattern.CASE_INSENSITIVE);
+               Matcher m = body.matcher(html);
+               if (m.find()) {
+                       html = m.group(1);
+                       Pattern fixup = Pattern.compile("<(\\w+) */>");;
+                       m = fixup.matcher(html);
+                       html = m.replaceAll("<$1>");
+                       m = Pattern.compile("[\\r\\n]+").matcher(html);
+                       html = m.replaceAll(" ");
+               }
+               String whole_msg = "<html><h1>Error</h1>"+msg+"<h1>PCTB Server said:</h1><blockquote>"+html+"</blockquote>";
+               //System.err.println("###" + whole_msg + "###");
+
+               JOptionPane.showMessageDialog(frame,whole_msg,"Error",JOptionPane.ERROR_MESSAGE);
+       }
+       
        /**
        *       Run the data collection process, and upload the results. This is the method
        *       that calls most of the other worker methods for the process. If an error occurs,
@@ -381,7 +400,7 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
 
                ArrayList<ArrayList<String>> data = getData(t);
 
-               if (uploadToYarrg) {
+               if (uploadToYarrg && yarrgts != null) {
                        pm.setNote("Preparing data for Yarrg");
                        pm.setProgress(10);
 
@@ -451,6 +470,7 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                        writeBuySellOffers(buys,sells,offerCount,out);
                        out.finish();
                        InputStream in = sendInitialData(new ByteArrayInputStream(outStream.toByteArray()));
+                       if (in == null) return;
                        pm.setProgress(80);
                        if(pm.isCanceled()) {
                                return;
@@ -785,6 +805,16 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                writeOffers(out,sells);
        }
        
+       private String readstreamstring(InputStream in) throws IOException {
+               StringBuilder sb = new StringBuilder();
+               BufferedReader br = new BufferedReader(new InputStreamReader(in));
+               String str;
+               while((str = br.readLine()) != null) {
+                       sb.append(str+"\n");
+               }
+               return sb.toString();
+       }
+
        /**
        *       Sends the data to the server via multipart-formdata POST,
        *       with the gzipped data as a file upload.
@@ -794,7 +824,12 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
        private InputStream sendInitialData(InputStream file) throws IOException {
                ClientHttpRequest http = new ClientHttpRequest(PCTB_HOST_URL + "upload.php");
                http.setParameter("marketdata","marketdata.gz",file,"application/gzip");
-               return http.post();
+               if (!http.post()) {
+                       String err = readstreamstring(http.resultstream());
+                       error("Error sending initial data:\n"+err);
+                       return null;
+               }
+               return http.resultstream();
        }
        
        /**
@@ -818,13 +853,7 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
        *       @param in stream of data from the server to read
        */
        private void finishUpload(InputStream in) throws IOException {
-               StringBuilder sb = new StringBuilder();
-               BufferedReader br = new BufferedReader(new InputStreamReader(in));
-               String str;
-               while((str = br.readLine()) != null) {
-                       sb.append(str+"\n");
-               }
-               String html = sb.toString();
+               String html = readstreamstring(in);
                //System.out.println(html);
                String topIsland = "0", ocean, islandNum, action, forceReload, filename;
                Matcher m;
@@ -865,7 +894,7 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                                                                islandName +"\" on " + myOceansList.length + " oceans:","Choose Ocean",
                                                                JOptionPane.QUESTION_MESSAGE, null, myOceansList, null);
                                                        if(option == null) {
-                                                               error("Unable to determine the current island!");
+                                                               error_html("Unable to determine the current island!", html);
                                                                return;
                                                        }
                                                        ocean = islandNumbers.get(option).toString();
@@ -873,11 +902,11 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                                                        ocean = myOceanNums.get(0).toString();
                                                }
                                        } else {
-                                               error("Unknown island!");
+                                               error_html("Unknown island or other problem!", html);
                                                return;
                                        }
                                } else {
-                                       error("Unable to determine island name from the client!");
+                                       error_html("Unable to determine island name from the client!", html);
                                        return;
                                }
                        } else {
@@ -889,14 +918,15 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                Pattern oceanIslandNum = Pattern.compile("islands\\[" + ocean + "\\]\\[\\d+\\]=new Option\\(\"" + islandName + "\",(\\d+)");
                m = oceanIslandNum.matcher(html);
                if(!m.find()) {
-                       error("This does not seem to be a valid island! Unable to upload.");
+                       error_html("This does not seem to be a valid island! Unable to upload.", html);
                        return;
                }
                islandNum = m.group(1);
                Pattern params = Pattern.compile("(?s)<input type=\"hidden\" name=\"action\" value=\"([^\"]+)\" />.+?<input type=\"hidden\" name=\"forcereload\" value=\"([^\"]+)\" />.+?<input type=\"hidden\" name=\"filename\" value=\"([^\"]+)\" />");
                m = params.matcher(html);
                if(!m.find()) {
-                       error("The PCTB server returned unusual data. Maybe you're using an old version of the uploader?");
+                       error_html("The PCTB server returned unusual data. Maybe you're using an old version of the uploader?",
+                                  html);
                        return;
                }
                action = m.group(1);
@@ -904,30 +934,33 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
                filename = m.group(3);
                URL get = new URL(PCTB_HOST_URL + "upload.php?topisland=" + topIsland + "&ocean=" + ocean + "&island="
                        + islandNum + "&action=" + action + "&forcereload=" + forceReload + "&filename=" + filename);
-               // System.out.println(get);
-               BufferedReader br2 = new BufferedReader(new InputStreamReader(get.openStream()));
-               sb = new StringBuilder();
-               while((str = br2.readLine()) != null) {
-                       sb.append(str+"\n");
-               }
+               String complete = readstreamstring(get.openStream());
                Pattern done = Pattern.compile("Your data has been integrated into the database. Thank you!");
-               m = done.matcher(sb.toString());
+               m = done.matcher(complete);
                if(m.find()) {
                        //System.out.println("FILE upload successful!!!");
                } else {
-                       error("Something was wrong with the final upload parameters!");
-                       System.err.println(sb.toString());
-                       System.err.println(html);
+                       error_html("Something was wrong with the final upload parameters!", complete);
                }
        }
 
+    private InputStream post_for_yarrg(ClientHttpRequest http) throws IOException {
+       if (!http.post()) {
+           String err = readstreamstring(http.resultstream());
+           error("<html><h1>Error reported by YARRG server</h1>\n" + err);
+           return null;
+       }
+       return http.resultstream();
+    }
+
     private String getYarrgTimestamp() throws IOException {
        ClientHttpRequest http = new ClientHttpRequest (YARRG_URL);
        http.setParameter("clientname", YARRG_CLIENTNAME);
        http.setParameter("clientversion", YARRG_CLIENTVERSION);
        http.setParameter("clientfixes", YARRG_CLIENTFIXES);
        http.setParameter("requesttimestamp", "y");
-       InputStream in = http.post();
+       InputStream in = post_for_yarrg(http);
+       if (in == null) return null;
        BufferedReader br = new BufferedReader(new InputStreamReader(in));
        String tsresult = br.readLine();
        return tsresult.substring(3, tsresult.length()-1);
@@ -948,7 +981,8 @@ public class MarketUploader implements TopLevelWindowListener, GUIInitializedLis
        http.setParameter("ocean", ocean);
        http.setParameter("island", island);
        http.setParameter("data", "deduped.tsv.gz", file, "application/octet-stream");
-       InputStream in = http.post();
+       InputStream in = post_for_yarrg(http);
+       if (in == null) return;
        BufferedReader br = new BufferedReader(new InputStreamReader(in));
        String yarrgresult; 
        while((yarrgresult = br.readLine()) != null) {