From: Matthew Vernon <matthew@debian.org>
Date: Sun, 16 Dec 2018 19:00:36 +0000 (+0000)
Subject: Re-instate the blocklist of banned posters
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~webstump/git?p=modbot-ulm.git;a=commitdiff_plain;h=beee9c129ef2692c2138f31260e64ff7972338c7

Re-instate the blocklist of banned posters

This is largely a revert of f74ee06e256c2470ad5ed264b090486856258b7f
but doesn't add the "add poster to ban-list" button, per Todal request.
---

diff --git a/webstump/doc/help/filter-lists.html b/webstump/doc/help/filter-lists.html
index 6a1199c..fe7fad7 100644
--- a/webstump/doc/help/filter-lists.html
+++ b/webstump/doc/help/filter-lists.html
@@ -15,6 +15,9 @@ The algorithm for every incoming article is as follows:
 
 <OL>
 
+  <LI> Reject message if the author is listed in <A
+       HREF=##bad.posters.list>the List of Banned Posters.</A>.
+
   <LI> File message for human review if the author is listed in <A
        HREF=##watch.posters.list>the List of Untrusted Posters</A>.
 
diff --git a/webstump/scripts/filter.lib.pl b/webstump/scripts/filter.lib.pl
index 891f7c9..b82a55a 100644
--- a/webstump/scripts/filter.lib.pl
+++ b/webstump/scripts/filter.lib.pl
@@ -92,6 +92,11 @@ sub review_incoming_message { # Newsgroup, From, Subject, RealSubject, Message,
   my $from = pop( @_ );
   my $newsgroup = pop( @_ );
 
+  if( &name_is_in_list( $from, "bad.posters.list" ) ) {
+    &process_approval_decision( $subject, $newsgroup, $dir, "reject blocklist", "", "auto bad poster" );
+    return;
+  }
+
   my $warning_file = &article_file_name( $dir ) . "/stump-warning.txt";
   my $match;
 
diff --git a/webstump/scripts/html_output.pl b/webstump/scripts/html_output.pl
index a974628..d9772d0 100644
--- a/webstump/scripts/html_output.pl
+++ b/webstump/scripts/html_output.pl
@@ -265,8 +265,8 @@ Add poster to watch list</INPUT>
 
 <BR><BR>
 <I>
-NOTE: Decisions to watchlist and whitelist posters can be reversed by 
-editing the respective lists of whitelisted and watchlisted posters.
+NOTE: Decisions to ban, watchlist and whitelist posters can be reversed by
+editing the respective lists of banlisted, whitelisted and watchlisted posters.
 ";
 
   &link_to_help( "filter-lists", "automatic filtering and filter lists, blacklisting and preapproved threads." );
@@ -762,6 +762,7 @@ sub html_newsgroup_management {
 
     <OPTION VALUE=good.posters.list>Good Posters List
     <OPTION VALUE=watch.posters.list>Suspicious Posters List
+    <OPTION VALUE=bad.posters.list>Banned Posters List
     <OPTION VALUE=watch.words.list>Suspicious Words List
 
   </SELECT>
diff --git a/webstump/scripts/webstump.lib.pl b/webstump/scripts/webstump.lib.pl
index 45ff3d7..379cf06 100644
--- a/webstump/scripts/webstump.lib.pl
+++ b/webstump/scripts/webstump.lib.pl
@@ -398,6 +398,7 @@ sub check_config_list {
  &user_error( "invalid list name $list_to_edit" )
     if( $list_to_edit ne "good.posters.list"
         && $list_to_edit ne "watch.posters.list"
+        && $list_to_edit ne "bad.posters.list"
         && $list_to_edit ne "watch.words.list" );
 
   return &untaint( $list_to_edit );