From: WebSTUMP <webstump@chiark.greenend.org.uk>
Date: Thu, 22 Nov 2012 15:06:34 +0000 (+0000)
Subject: webstump: do not alter the moderator's post disposition when it differs from the... 
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~webstump/git?p=modbot-mtm.git;a=commitdiff_plain;h=ba1a60e8c390874d2fbb484c29d23524e945f934

webstump: do not alter the moderator's post disposition when it differs from the poster disposition.  For a poster being banned, we can reject with any reason.  For a poster being passlisted, bomb out with an internal error if the post decision wasn't approve (bad UI but it will do)
---

diff --git a/webstump/scripts/webstump.lib.pl b/webstump/scripts/webstump.lib.pl
index cafa469..9b7fc79 100644
--- a/webstump/scripts/webstump.lib.pl
+++ b/webstump/scripts/webstump.lib.pl
@@ -585,8 +585,8 @@ sub approval_decision {
       $decision = "reject thread" if $thread_decision eq "ban";
       $decision = "approve" if $thread_decision eq "preapprove";
 
-      $decision = "reject blocklist" if $poster_decision eq "ban";
-      $decision = "approve" if $poster_decision eq "preapprove";
+      #$decision = "reject blocklist" if $poster_decision eq "ban";
+      die if $decision ne "approve" and $poster_decision eq "preapprove";
 
       if( -r $fullpath && open( MESSAGE, "$fullpath" ) ) {
         my $RealSubject = "", $From = "", $Subject = "";