From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri, 19 Mar 2010 11:54:37 +0000 (+0000)
Subject: Remove useless use of cat causing pipefail problems
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~webstump/git?p=modbot-mtm.git;a=commitdiff_plain;h=6ea48c961acca9513fea8bd6dd4b8bc400e04252

Remove useless use of cat causing pipefail problems
---

diff --git a/stump/etc/modack.approved.INO b/stump/etc/modack.approved.INO
index 17f9717..cdc3d1c 100755
--- a/stump/etc/modack.approved.INO
+++ b/stump/etc/modack.approved.INO
@@ -3,10 +3,16 @@
 set -e
 set -o pipefail
 
+if [ $# != 1 ]; then
+	echo >&2 "wrong # args to $0: $*"
+	exit 1
+fi
+input="$1"
+
 (
-  cat $@ | formail -rt -I "Reply-To: $NOACK" \
-        -I "X-Webstump-Event: approve" \
-	$MAILOUT_ACCEPTACK_FORMAIL_ARGS
+  formail <"$input" -rt -I "Reply-To: $NOACK"	\
+	        -I "X-Webstump-Event: approve"	\
+		$MAILOUT_ACCEPTACK_FORMAIL_ARGS
   cat <<_EOB_
 Hello,