From: Matthew Vernon <matthew@debian.org>
Date: Sun, 5 Jan 2014 07:36:09 +0000 (+0000)
Subject: Replace drop-down with radio buttons
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~webstump/git?a=commitdiff_plain;h=f21bfd5ecc5dda85b60265d48e15a48e1439a490;p=modbot-uram.git

Replace drop-down with radio buttons

Todal wanted a simpler UI for the single-article screen, rather more
like the version in the multiple-article screen. This does that, by
stripping out the old drop-down (and the thread status button), and
replacing it with radio buttons for all the approve/hold/reject
options.

Also, make it clearer that the "Comment" field is to go with the
rejection email to the poster.
---

diff --git a/webstump/scripts/html_output.pl b/webstump/scripts/html_output.pl
index 4b0e576..460a0d3 100644
--- a/webstump/scripts/html_output.pl
+++ b/webstump/scripts/html_output.pl
@@ -245,19 +245,14 @@ sub html_moderate_article {
   print "
 <INPUT NAME=action VALUE=approval_decision TYPE=hidden>";
   &html_print_credentials;
-  print "<SELECT NAME=\"decision_$file\">
-<OPTION VALUE=\"approve\">Approve</OPTION>
-<OPTION VALUE=\"leave\" SELECTED>Put to back of queue</OPTION>
-<OPTION VALUE=\"consider\">Back of queue, adding mark requesting further consideration</OPTION>
-";
-
-      foreach (sort(keys %rejection_reasons)) {
-        print "<OPTION VALUE=\"reject $_\">Reject -- $rejection_reasons{$_}</OPTION>\n";
-      }
-
-      print "<BR>";
+        print "<INPUT TYPE=radio NAME=\"decision_$file\" VALUE=approve>Approve\n";
+        print "<INPUT TYPE=radio NAME=\"decision_$file\" VALUE=skip>Leave\n";
+        print "<INPUT TYPE=radio NAME=\"decision_$file\" VALUE=leave>Back of queue\n";
+        foreach (@short_rejection_reasons) {
+          print "<INPUT TYPE=radio NAME=\"decision_$file\" VALUE=\"reject $_\">Reject \u$_\n";
+        }
 
-      print "</SELECT><BR> Comment: <INPUT NAME=comment VALUE=\"\" SIZE=80><BR>";
+      print "<BR> Comment (to poster, in rejection message): <INPUT NAME=comment VALUE=\"\" SIZE=80><BR>";
 
   print "<BR>
 <INPUT TYPE=radio NAME=poster_decision VALUE=nothing CHECKED>Don't change poster's status</INPUT>
@@ -266,15 +261,6 @@ sub html_moderate_article {
 <INPUT TYPE=radio NAME=poster_decision VALUE=ban 
   ONCLICK=\"alert( 'Banning a poster is a controversial practice'); \"
 > Ban All Posts by this Person (Careful!)</INPUT>
-<BR><BR>
-<INPUT TYPE=radio NAME=thread_decision VALUE=nothing CHECKED>Don't change thread's status</INPUT>
-<!-- <INPUT TYPE=radio NAME=thread_decision VALUE=preapprove>Preapprove thread, by Subject:</INPUT> -->
-<BR>
-
-<!-- <INPUT TYPE=radio NAME=thread_decision VALUE=ban
-  ONCLICK=\"alert( 'Banning a thread is a controversial practice'); \"
->Ban Entire Thread By Subject (Careful!)</INPUT> -->
-<!-- <INPUT TYPE=radio NAME=thread_decision VALUE=watch>Put Entire thread on a Watch, by Subject:</INPUT> -->
 
 <BR><BR>
 <I>