From 073cc23b4f8d5e9c4d74e9a15a6c0f13a55cf4e6 Mon Sep 17 00:00:00 2001 Message-Id: <073cc23b4f8d5e9c4d74e9a15a6c0f13a55cf4e6.1716557755.git.mdw@distorted.org.uk> From: Mark Wooding Date: Sat, 20 Dec 2008 11:39:32 +0000 Subject: [PATCH] uslip: Don't let gobblers leak file descriptors. Organization: Straylight/Edgeware From: Mark Wooding The otherwise aptly-named gobbler_close function neglected to actually close its file descriptor. --- uslip/uslip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uslip/uslip.c b/uslip/uslip.c index eb60eb69..245f1ec0 100644 --- a/uslip/uslip.c +++ b/uslip/uslip.c @@ -193,7 +193,7 @@ static void destroy_pkq(pkq *q) */ static void gobbler_close(gobbler *g) - { if (g->f.fd != -1) { sel_rmfile(&g->f); g->f.fd = -1; } } + { if (g->f.fd != -1) { sel_rmfile(&g->f); close(g->f.fd); g->f.fd = -1; } } static void gobbler_destroy(gobbler *g) { gobbler_close(g); DESTROY(g); } -- [mdw]