From: Mark Wooding <mdw@distorted.org.uk>
Date: Sat, 20 Dec 2008 11:39:32 +0000 (+0000)
Subject: uslip: Don't let gobblers leak file descriptors.
X-Git-Tag: 1.0.0pre8~43
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/tripe/commitdiff_plain/073cc23b4f8d5e9c4d74e9a15a6c0f13a55cf4e6?ds=sidebyside

uslip: Don't let gobblers leak file descriptors.

The otherwise aptly-named gobbler_close function neglected to actually
close its file descriptor.
---

diff --git a/uslip/uslip.c b/uslip/uslip.c
index eb60eb69..245f1ec0 100644
--- a/uslip/uslip.c
+++ b/uslip/uslip.c
@@ -193,7 +193,7 @@ static void destroy_pkq(pkq *q)
  */
 
 static void gobbler_close(gobbler *g)
-  { if (g->f.fd != -1) { sel_rmfile(&g->f); g->f.fd = -1; } }
+  { if (g->f.fd != -1) { sel_rmfile(&g->f); close(g->f.fd); g->f.fd = -1; } }
 
 static void gobbler_destroy(gobbler *g) { gobbler_close(g); DESTROY(g); }