From d34d6e351e9708f4a5ce519e508abbc418285b5e Mon Sep 17 00:00:00 2001 Message-Id: From: Mark Wooding Date: Mon, 24 Aug 2009 10:28:33 +0200 Subject: [PATCH] When reading a config value, pick the last value, not the first Organization: Straylight/Edgeware From: Karl Wiberg When reading the config values, we save all values for a given key in a list, in the order we see them. Then, when asked for one value, we used to return the _first_ value in the list. But the correct thing to do in order to allow local configs (like the repository's .git/config) to override global configs (like ~/.gitconfig) is to return the _last_ value. Signed-off-by: Karl Wiberg --- stgit/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stgit/config.py b/stgit/config.py index 6f84b10..bfb117d 100644 --- a/stgit/config.py +++ b/stgit/config.py @@ -57,7 +57,7 @@ class GitConfig: self.load() if name not in self.__cache: self.__cache[name] = [self.__defaults.get(name, None)] - return self.__cache[name][0] + return self.__cache[name][-1] def getall(self, name): self.load() -- [mdw]