chiark / gitweb /
Using delete_patch while deleting a branch is broken
authorChuck Lever <cel@netapp.com>
Thu, 17 Nov 2005 02:39:30 +0000 (21:39 -0500)
committerCatalin Marinas <catalin.marinas@gmail.com>
Thu, 17 Nov 2005 10:36:37 +0000 (10:36 +0000)
commit5a636ab334ec9414052aaf228010f3e43760b733
treead967c0146bbe4661d737c17cd83c2504a5ec527
parentfcc1ad70be5ff89996358b6d770cd229fec2a3ba
Using delete_patch while deleting a branch is broken

"stg branch --force --delete" takes forever, and often leaves the
repository in a broken state.  The reason for this is the use of
stack.delete_patch() to delete the patches before removing the series.

The problem is delete_patch() will try to pop the patches, which changes
the head link.  After the branch deletion is complete, HEAD will point to
.git/refs/heads/current-branch, but the contents of current-branch will be
the old base of the deleted branch.

Signed-off-by: Chuck Lever <cel@netapp.com>
stgit/stack.py