From: Mark Wooding <mdw@distorted.org.uk>
Date: Mon, 9 Oct 2017 11:25:52 +0000 (+0100)
Subject: el/dot-emacs.el: Use advice to hack the fill prefix.
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/profile/commitdiff_plain/b8c659bb0964f68e8a2e88fe0b0621a08140a680

el/dot-emacs.el: Use advice to hack the fill prefix.

The old thing with `fset' was awful, and presumably dates back to before
I knew about advice.
---

diff --git a/el/dot-emacs.el b/el/dot-emacs.el
index 0e93221..1be5746 100644
--- a/el/dot-emacs.el
+++ b/el/dot-emacs.el
@@ -1009,10 +1009,6 @@ (defvar mdw-hanging-indents
   "*Standard regexp matching parts of a hanging indent.
 This is mainly useful in `auto-fill-mode'.")
 
-;; Setting things up.
-
-(fset 'mdw-do-auto-fill (symbol-function 'do-auto-fill))
-
 ;; Utility functions.
 
 (defun mdw-maybe-tabify (s)
@@ -1068,11 +1064,11 @@ (defun mdw-choose-dynamic-fill-prefix ()
 	     (save-match-data
 	       (mdw-examine-fill-prefixes mdw-fill-prefix))))))
 
-(defun do-auto-fill ()
+(defadvice do-auto-fill (around mdw-dynamic-fill-prefix () activate compile)
   "Handle auto-filling, working out a dynamic fill prefix in the
 case where there isn't a sensible static one."
   (let ((fill-prefix (mdw-choose-dynamic-fill-prefix)))
-    (mdw-do-auto-fill)))
+    ad-do-it))
 
 (defun mdw-fill-paragraph ()
   "Fill paragraph, getting a dynamic fill prefix."