From: Mark Wooding <mdw@distorted.org.uk>
Date: Sat, 7 Jan 2012 15:58:49 +0000 (+0000)
Subject: bin/mdw-build: Discard `tar' errors when searching for `.../RELEASE'.
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/profile/commitdiff_plain/98a2d95e575804674af77388f49b6ae27277a9b3

bin/mdw-build: Discard `tar' errors when searching for `.../RELEASE'.

GNU `tar' reports a vague `write error' as a result of the broken pipe
caused by the following `grep' finding a successful match.  This isn't
useful.  In our case, we don't care about this, since either we've found
the file anyway (so we're happy) or we didn't (in which case we'll fail
anyway).

The report, which makes its way to stderr even in quiet mode, is
worrying until you learn to ignore it, at which point it may hide a more
serious problem.
---

diff --git a/bin/mdw-build b/bin/mdw-build
index 9e51298..d8be795 100755
--- a/bin/mdw-build
+++ b/bin/mdw-build
@@ -246,7 +246,7 @@ esac
 
 cd $releasepath
 
-if ! tar tfz $buildpath/$distdir.tar.gz | grep -q RELEASE; then
+if ! tar tf $buildpath/$distdir.tar.gz 2>/dev/null | grep -q RELEASE; then
   fail "missing RELEASE file in distribution"
 fi