/* SK is (or at least might be) a Unix-domain socket we created when an
* Internet socket was asked for. We've decided it should be an Internet
- * socket after all, with family AF_HINT, so convert it.
+ * socket after all, with family AF_HINT, so convert it. If TMP is not null,
+ * then don't replace the existing descriptor: store the new socket in *TMP
+ * and return zero.
*/
-static int fixup_real_ip_socket(int sk, int af_hint)
+static int fixup_real_ip_socket(int sk, int af_hint, int *tmp)
{
int nsk;
int type;
} while (0);
OPTS(FIX)
#undef FIX
- if ((f = fcntl(sk, F_GETFL)) < 0 ||
- (fd = fcntl(sk, F_GETFD)) < 0 ||
- fcntl(nsk, F_SETFL, f) < 0 ||
- dup2(nsk, sk) < 0) {
+ if (tmp)
+ *tmp = nsk;
+ else {
+ if ((f = fcntl(sk, F_GETFL)) < 0 ||
+ (fd = fcntl(sk, F_GETFD)) < 0 ||
+ fcntl(nsk, F_SETFL, f) < 0 ||
+ dup2(nsk, sk) < 0) {
+ close(nsk);
+ return (-1);
+ }
+ unlink(sun.sun_path);
close(nsk);
- return (-1);
- }
- unlink(sun.sun_path);
- close(nsk);
- if (fcntl(sk, F_SETFD, fd) < 0) {
- perror("noip: fixup_real_ip_socket F_SETFD");
- abort();
+ if (fcntl(sk, F_SETFD, fd) < 0) {
+ perror("noip: fixup_real_ip_socket F_SETFD");
+ abort();
+ }
}
return (0);
}
socklen_t mylen = sizeof(*sun);
if (acl_allows_p(connect_real, *sa)) {
- if (fixup_real_ip_socket(sk, (*sa)->sa_family)) return (-1);
+ if (fixup_real_ip_socket(sk, (*sa)->sa_family, 0)) return (-1);
} else {
if (real_getsockname(sk, SA(sun), &mylen) < 0) return (-1);
if (sun->sun_family == AF_UNIX) {
int socketpair(int pf, int ty, int proto, int *sk)
{
- if (pf == PF_INET) {
+ if (family_known_p(pf)) {
pf = PF_UNIX;
proto = 0;
}
if (family_known_p(sa->sa_family)) {
PRESERVING_ERRNO({
if (acl_allows_p(bind_real, sa)) {
- if (fixup_real_ip_socket(sk, sa->sa_family))
+ if (fixup_real_ip_socket(sk, sa->sa_family, 0))
return (-1);
} else {
encode_inet_addr(&sun, sa, WANT_FRESH);
{
struct sockaddr_un sun;
- if (to && to->sa_family == AF_INET) {
+ if (to && family_known_p(to->sa_family)) {
PRESERVING_ERRNO({
do_implicit_bind(sk, &to, &tolen, &sun);
});
const struct sockaddr *sa;
struct msghdr mymsg;
- if (msg->msg_name && SA(msg->msg_name)->sa_family == AF_INET) {
+ if (msg->msg_name && family_known_p(SA(msg->msg_name)->sa_family)) {
PRESERVING_ERRNO({
sa = SA(msg->msg_name);
mymsg = *msg;