From: Mark Wooding <mdw@distorted.org.uk>
Date: Thu, 29 Mar 2012 18:50:37 +0000 (+0100)
Subject: xtitle.c: Ignore boring return codes better.
X-Git-Tag: 1.2.8.1~1^2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/misc/commitdiff_plain/4754c66dd2d7cb9cc9e11fdd66cc03fc109a838a

xtitle.c: Ignore boring return codes better.

I'm not convinced that ignoring the write code when reading the
current title is clever, but that code is hopelessly broken anyway.
---

diff --git a/xtitle.c b/xtitle.c
index 29607cb..a6696d3 100644
--- a/xtitle.c
+++ b/xtitle.c
@@ -6,13 +6,14 @@
 #include <string.h>
 #include <fcntl.h>
 
+#define IGNORE(x) do if (x); while (0)
+
 int main(int argc, char *argv[])
 {
   int query = 0;
   int fd;
   int openned = 0;
   int i;
-  int hunoz;
 
   for (;;) {
     i = getopt(argc, argv, "q");
@@ -52,13 +53,13 @@ int main(int argc, char *argv[])
 
   if (!query) {
     char sp = ' ';
-    hunoz = write(fd, "\33]0;", 4);
+    IGNORE(write(fd, "\33]0;", 4));
     for (i = optind; i < argc; i++) {
-      hunoz = write(fd, argv[i], strlen(argv[i]));
+      IGNORE(write(fd, argv[i], strlen(argv[i])));
       if (i < argc - 1)
-	hunoz = write(fd, &sp, 1);
+	IGNORE(write(fd, &sp, 1));
     }
-    hunoz = write(fd, "\7", 2);
+    IGNORE(write(fd, "\7", 2));
   } else {
     struct termios o, n;
     char hack;
@@ -72,7 +73,7 @@ int main(int argc, char *argv[])
     n.c_cflag &= ~(CSIZE|PARENB);
     n.c_cflag |= CS8;
     tcsetattr(fd, TCSAFLUSH, &n);
-    hunoz = write(fd, "\33[21t", 5);
+    IGNORE(write(fd, "\33[21t", 5));
 
     while (state != -1) {
       if (read(fd, &hack, 1) < 1)