From 98c3d1f1297d820bb96ad4861cb9fc4ddbfb36ac Mon Sep 17 00:00:00 2001 Message-Id: <98c3d1f1297d820bb96ad4861cb9fc4ddbfb36ac.1714683847.git.mdw@distorted.org.uk> From: Mark Wooding Date: Sun, 15 Nov 2009 13:14:18 +0000 Subject: [PATCH] comments Organization: Straylight/Edgeware From: Richard Kettlewell --- disobedience/queue-generic.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/disobedience/queue-generic.c b/disobedience/queue-generic.c index 5a2a8ea..7958aff 100644 --- a/disobedience/queue-generic.c +++ b/disobedience/queue-generic.c @@ -492,7 +492,15 @@ static gboolean ql_drag_motion(GtkWidget *w, gtk_tree_view_set_drag_dest_row(GTK_TREE_VIEW(w), NULL, 0); } } - return TRUE; + /* TODO _something_ is not quite right here. Supposedly if action=0 we + * should probably be returning FALSE; _but_ actually we always want to + * support dropping, as dropping into the big empty space at the bottom + * should be the same as dropping at the end of the last row. + * + * As the code stands the drop works but the visual feedback is not quite + * right. + */ + return TRUE; /* We are (always) in a drop zone */ } /** @brief Called when a drag moves leaves a candidate destination -- [mdw]