From: Mark Wooding <mdw@distorted.org.uk>
Date: Tue, 10 Jul 2018 10:26:56 +0000 (+0100)
Subject: server/gstdecode.c: Report more useful messages for missing plugins.
X-Git-Tag: 5.2~35
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/c54fec77e8e079bbcd6dc522c979e82e78e4f582

server/gstdecode.c: Report more useful messages for missing plugins.
---

diff --git a/server/gstdecode.c b/server/gstdecode.c
index 0ebe83a..7644475 100644
--- a/server/gstdecode.c
+++ b/server/gstdecode.c
@@ -215,6 +215,10 @@ static void prepare_pipeline(void)
   GstCaps *caps;
   const struct stream_header *fmt = &config->sample_format;
 
+  if(!source || !decode || !resample || !convert || !sink)
+    disorder_fatal(0, "failed to create GStreamer elements: "
+                   "need base and good plugins");
+
 #ifndef HAVE_GSTREAMER_0_10
   static const struct fmttab {
     const char *fmt;
@@ -291,6 +295,9 @@ static void prepare_pipeline(void)
    */
   if(mode != OFF) {
     gain = gst_element_factory_make("rgvolume", "gain");
+    if(!gain)
+      disorder_fatal(0, "failed to create GStreamer elements: "
+                     "need base and good plugins");
     g_object_set(gain,
                  "album-mode", mode == ALBUM,
                  "fallback-gain", fallback,