From: rjk@greenend.org.uk <>
Date: Sat, 12 Jan 2008 11:23:05 +0000 (+0000)
Subject: Limit how long tests/play.py will wait
X-Git-Tag: 3.0~62
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/bf219db9f91e923842dd54d6534156c92a583c8a?hp=87b5259b3ebe094ed7571de9cd2f7614d6488f66

Limit how long tests/play.py will wait
---

diff --git a/tests/play.py b/tests/play.py
index ce5cbb1..43deaff 100755
--- a/tests/play.py
+++ b/tests/play.py
@@ -44,11 +44,15 @@ def test():
     assert c.enabled() == True
     p = c.playing()
     r = c.recent()
+    limit = 60
     while not((p is not None and p['id'] == i)
-              or (len(filter(lambda t: t['track'] == track and 'submitter' in t, r)) > 0)):
+              or (len(filter(lambda t: t['track'] == track
+                             and 'submitter' in t, r)) > 0)) and limit > 0:
         time.sleep(1)
         p = c.playing()
         r = c.recent()
+        limit -= 1
+    assert limit > 0, "check track did complete in a reasonable time"
     print " checking track turned up in recent list"
     while (p is not None and p['id'] == i):
         time.sleep(1)
@@ -75,9 +79,12 @@ def test():
         c.scratch(i)
         print " waiting for track to finish"
         p = c.playing()
-        while (p is not None and p['id'] == i):
+        limit = 60
+        while (p is not None and p['id'] == i) and limit > 0:
             time.sleep(1)
             p = c.playing()
+            limit -= 1
+        assert limit > 0, "check track finishes in a reasonable period"
         print " checking scratched track turned up in recent list"
         r = c.recent()
         ts = filter(lambda t: t['id'] == i, r)