From: Richard Kettlewell <richard@deodand>
Date: Thu, 17 Jun 2010 19:48:43 +0000 (+0100)
Subject: Check correctly for the case where no player is found.
X-Git-Tag: branchpoint-5.1~74^2~2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/8141805c7a72a6c782ac0663ee0c916af8ef7868?hp=375d9478a5b6b14bfb5f6e1a054e900a18e40717

Check correctly for the case where no player is found.
---

diff --git a/server/play.c b/server/play.c
index 99ef483..8406238 100644
--- a/server/play.c
+++ b/server/play.c
@@ -300,7 +300,7 @@ static int start(ev_source *ev,
 
   D(("start %s", q->id));
   /* Find the player plugin. */
-  if(!(player = find_player(q)) < 0)
+  if(!(player = find_player(q)))
     return START_HARDFAIL;              /* No player */
   if(!(q->pl = open_plugin(player->s[1], 0)))
     return START_HARDFAIL;
@@ -395,7 +395,7 @@ int prepare(ev_source *ev,
   if(q->prepared || q->preparing)
     return START_OK;
   /* Find the player plugin */
-  if(!(player = find_player(q)) < 0) 
+  if(!(player = find_player(q))) 
     return START_HARDFAIL;              /* No player */
   q->pl = open_plugin(player->s[1], 0);
   q->type = play_get_type(q->pl);