From: Richard Kettlewell <rjk@greenend.org.uk>
Date: Thu, 29 Nov 2007 19:35:07 +0000 (+0000)
Subject: tighten up liveness behavior
X-Git-Tag: 1.5.99+dev10~42
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/4a99f7ba7e2e1ecc7a09528618e1e3ca54f5727d?ds=sidebyside

tighten up liveness behavior
---

diff --git a/lib/selection.c b/lib/selection.c
index c69e83d..58ff5d1 100644
--- a/lib/selection.c
+++ b/lib/selection.c
@@ -44,9 +44,11 @@ hash *selection_new(void) {
  * are not marked as live.
  */
 void selection_set(hash *h, const char *key, int selected) {
-  if(selected)
-    hash_add(h, key, xmalloc_noptr(sizeof (int)), HASH_INSERT_OR_REPLACE);
-  else
+  if(selected) {
+    int *const liveness = xmalloc_noptr(sizeof (int));
+    *liveness = 0;
+    hash_add(h, key, liveness, HASH_INSERT_OR_REPLACE);
+  } else
     hash_remove(h, key);
 }
 
@@ -96,7 +98,7 @@ static int selection_cleanup_callback(const char *key,
 /** @brief Delete all non-live keys from a selection
  * @param h Hash representing selection
  *
- * See selection_live().
+ * After cleanup, no keys are marked as live.
  */
 void selection_cleanup(hash *h) {
   hash_foreach(h, selection_cleanup_callback, h);