From: Richard Kettlewell <rjk@greenend.org.uk>
Date: Sat, 28 Feb 2009 11:03:19 +0000 (+0000)
Subject: Turns out that GetMacOSStatusErrorString() and
X-Git-Tag: 5.0~185^2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/commitdiff_plain/1f3d2413174c3187de3fd8701d3ba26a0d1e4489?hp=ca6b4a12640792d416b9fcbeb4baa8a3b84285ff

Turns out that GetMacOSStatusErrorString() and
GetMacOSStatusCommentString() don't produce useful answers, at least
for sound-related errors.  Users will just have to put up with numeric
error codes.

Thanks so much, Apple.
---

diff --git a/lib/coreaudio.c b/lib/coreaudio.c
index 6231877..f6a8162 100644
--- a/lib/coreaudio.c
+++ b/lib/coreaudio.c
@@ -41,10 +41,7 @@ void coreaudio_fatal(OSStatus err, const char *fmt, ...) {
   byte_vasprintf(&msg, fmt, ap);
   va_end(ap);
 
-  disorder_fatal(0, "%s: error %d (%s, %s)",
-                 msg, (int)err,
-                 GetMacOSStatusErrorString(err),
-                 GetMacOSStatusCommentString(err));
+  disorder_fatal(0, "%s: error %u", msg, (unsigned)err);
 }
 
 /** @brief Return the default device ID */
@@ -147,7 +144,7 @@ AudioDeviceID coreaudio_getdevice(const char *name) {
   if(!ndevs)
     disorder_fatal(0, "no sound devices found");
   /* Try looking up by UID first */
-  found = coreaudio_find_device(kAudioDevicePropertyDeviceUID, //"UID",
+  found = coreaudio_find_device(-1*kAudioDevicePropertyDeviceUID, //"UID",
                                 devs, ndevs, dev, &adid);
   /* Failing that try looking up by name */
   if(!found)