X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~mdw/git/disorder/blobdiff_plain/5bac5b78c1046bd08a39d3d18c756bbf0566c629..0c1d42ad03f7e49b23755209f5b1f295cbe21f6b:/server/play.c diff --git a/server/play.c b/server/play.c index 3030901..a1384f8 100644 --- a/server/play.c +++ b/server/play.c @@ -39,6 +39,7 @@ static int start_child(struct queue_entry *q, static int prepare_child(struct queue_entry *q, const struct pbgc_params *params, void attribute((unused)) *bgdata); +static void ensure_next_scratch(ev_source *ev); /** @brief File descriptor of our end of the socket to the speaker */ static int speaker_fd = -1; @@ -59,8 +60,7 @@ static int speaker_terminated(ev_source attribute((unused)) *ev, int attribute((unused)) status, const struct rusage attribute((unused)) *rusage, void attribute((unused)) *u) { - fatal(0, "speaker subprocess %s", - wstat(status)); + disorder_fatal(0, "speaker subprocess %s", wstat(status)); } /** @brief Called when we get a message from the speaker process */ @@ -83,16 +83,34 @@ static int speaker_readable(ev_source *ev, int fd, case SM_FINISHED: /* scratched the playing track */ case SM_STILLBORN: /* scratched too early */ case SM_UNKNOWN: /* scratched WAY too early */ - if(playing && !strcmp(sm.id, playing->id)) + if(playing && !strcmp(sm.id, playing->id)) { + if((playing->state == playing_unplayed + || playing->state == playing_started) + && sm.type == SM_FINISHED) + playing->state = playing_ok; finished(ev); + } break; case SM_PLAYING: /* track ID is playing, DATA seconds played */ D(("SM_PLAYING %s %ld", sm.id, sm.data)); playing->sofar = sm.data; break; + case SM_ARRIVED: { + /* track ID is now prepared */ + struct queue_entry *q; + for(q = qhead.next; q != &qhead && strcmp(q->id, sm.id); q = q->next) + ; + if(q && q->preparing) { + q->preparing = 0; + q->prepared = 1; + /* We might be waiting to play the now-prepared track */ + play(ev); + } + break; + } default: - error(0, "unknown speaker message type %d", sm.type); + disorder_error(0, "unknown speaker message type %d", sm.type); } return 0; } @@ -104,7 +122,7 @@ void speaker_setup(ev_source *ev) { struct speaker_message sm; if(socketpair(PF_UNIX, SOCK_DGRAM, 0, sp) < 0) - fatal(errno, "error calling socketpair"); + disorder_fatal(errno, "error calling socketpair"); if(!(pid = xfork())) { exitfn = _exit; ev_signal_atfork(ev); @@ -124,7 +142,7 @@ void speaker_setup(ev_source *ev) { log_default == &log_syslog ? "--syslog" : "--no-syslog", (char *)0); #endif - fatal(errno, "error invoking %s", SPEAKER); + disorder_fatal(errno, "error invoking %s", SPEAKER); } ev_child(ev, pid, 0, speaker_terminated, 0); speaker_fd = sp[1]; @@ -134,7 +152,7 @@ void speaker_setup(ev_source *ev) { speaker_recv(speaker_fd, &sm); nonblock(speaker_fd); if(ev_fd(ev, ev_read, speaker_fd, speaker_readable, 0, "speaker read") < 0) - fatal(0, "error registering speaker socket fd"); + disorder_fatal(0, "error registering speaker socket fd"); } /** @brief Tell the speaker to reload its configuration */ @@ -196,7 +214,9 @@ static void finished(ev_source *ev) { * some time before the speaker reports it as finished) or when a non-raw * (i.e. non-speaker) player terminates. In the latter case it's imaginable * that the OS has buffered the last few samples. - * + * + * NB. The finished track might NOT be in the queue (yet) - it might be a + * pre-chosen scratch. */ static int player_finished(ev_source *ev, pid_t pid, @@ -230,10 +250,12 @@ static int player_finished(ev_source *ev, q->state = playing_ok; break; } - /* Regardless we always report and record the status and do cleanup for - * prefork calls. */ - if(status) - error(0, "player for %s %s", q->track, wstat(status)); + /* Report the status unless we killed it */ + if(status) { + if(!(q->killed && WIFSIGNALED(status) && WTERMSIG(status) == q->killed)) + disorder_error(0, "player for %s %s", q->track, wstat(status)); + } + /* Clean up any prefork calls */ if(q->type & DISORDER_PLAYER_PREFORK) play_cleanup(q->pl, q->data); q->wstat = status; @@ -267,7 +289,7 @@ static const struct stringlist *find_player(const struct queue_entry *q) { * @return @ref START_OK, @ref START_HARDFAIL or @ref START_SOFTFAIL * * This makes @p actually start playing. It calls prepare() if necessary and - * either sends an @ref SM_START command or invokes the player itself in a + * either sends an @ref SM_PLAY command or invokes the player itself in a * subprocess. * * It's up to the caller to set @ref playing and @c playing->state (this might @@ -280,7 +302,7 @@ static int start(ev_source *ev, D(("start %s", q->id)); /* Find the player plugin. */ - if(!(player = find_player(q)) < 0) + if(!(player = find_player(q))) return START_HARDFAIL; /* No player */ if(!(q->pl = open_plugin(player->s[1], 0))) return START_HARDFAIL; @@ -310,39 +332,16 @@ static int start(ev_source *ev, } } -/** @brief Child-process half of start() */ +/** @brief Child-process half of start() + * @return Process exit code + * + * Called in subprocess to execute non-raw-format players (via plugin). + */ static int start_child(struct queue_entry *q, const struct pbgc_params *params, void attribute((unused)) *bgdata) { int n; - /* Wait for a device to clear. This ugliness is now deprecated and will - * eventually be removed. */ - if(params->waitdevice) { - ao_initialize(); - if(*params->waitdevice) { - n = ao_driver_id(params->waitdevice); - if(n == -1) - fatal(0, "invalid libao driver: %s", params->waitdevice); - } else - n = ao_default_driver_id(); - /* Make up a format. */ - ao_sample_format format; - memset(&format, 0, sizeof format); - format.bits = 8; - format.rate = 44100; - format.channels = 1; - format.byte_format = AO_FMT_NATIVE; - int retries = 20; - struct timespec ts; - ts.tv_sec = 0; - ts.tv_nsec = 100000000; /* 0.1s */ - ao_device *device; - while((device = ao_open_live(n, &format, 0)) == 0 && retries-- > 0) - nanosleep(&ts, 0); - if(device) - ao_close(device); - } /* Play the track */ play_track(q->pl, params->argv, params->argc, @@ -354,6 +353,9 @@ static int start_child(struct queue_entry *q, /** @brief Prepare a track for later play * @return @ref START_OK, @ref START_HARDFAIL or @ref START_SOFTFAIL * + * This can be called either when we want to play the track or slightly before + * so that some samples are decoded and available in a buffer. + * * Only applies to raw-format (i.e. speaker-using) players; everything else * gets @c START_OK. */ @@ -365,31 +367,41 @@ int prepare(ev_source *ev, if(q->pid >= 0) return START_OK; /* If the track is already prepared, do nothing */ - if(q->prepared) + if(q->prepared || q->preparing) return START_OK; /* Find the player plugin */ - if(!(player = find_player(q)) < 0) + if(!(player = find_player(q))) return START_HARDFAIL; /* No player */ q->pl = open_plugin(player->s[1], 0); q->type = play_get_type(q->pl); if((q->type & DISORDER_PLAYER_TYPEMASK) != DISORDER_PLAYER_RAW) return START_OK; /* Not a raw player */ - const int rc = play_background(ev, player, q, prepare_child, NULL); + int rc = play_background(ev, player, q, prepare_child, NULL); if(rc == START_OK) { ev_child(ev, q->pid, 0, player_finished, q); - q->prepared = 1; + q->preparing = 1; + /* Actually the track is still "in flight" */ + rc = START_SOFTFAIL; } return rc; } -/** @brief Child-process half of prepare() */ +/** @brief Child-process half of prepare() + * @return Process exit code + * + * Called in subprocess to execute the decoder for a raw-format player. + * + * @todo We currently run the normalizer from here in a double-fork. This is + * unsatisfactory for many reasons: we can't prevent it outliving the main + * server and we don't adequately report its exit status. + */ static int prepare_child(struct queue_entry *q, const struct pbgc_params *params, void attribute((unused)) *bgdata) { /* np will be the pipe to disorder-normalize */ int np[2]; if(socketpair(PF_UNIX, SOCK_STREAM, 0, np) < 0) - fatal(errno, "error calling socketpair"); + disorder_fatal(errno, "error calling socketpair"); /* Beware of the Leopard! On OS X 10.5.x, the order of the shutdown * calls here DOES MATTER. If you do the SHUT_WR first then the SHUT_RD * fails with "Socket is not connected". I think this is a bug but @@ -415,15 +427,15 @@ static int prepare_child(struct queue_entry *q, "%s/speaker/socket", config->home); int sfd = xsocket(PF_UNIX, SOCK_STREAM, 0); if(connect(sfd, (const struct sockaddr *)&addr, sizeof addr) < 0) - fatal(errno, "connecting to %s", addr.sun_path); + disorder_fatal(errno, "connecting to %s", addr.sun_path); /* Send the ID, with a NATIVE-ENDIAN 32 bit length */ uint32_t l = strlen(q->id); if(write(sfd, &l, sizeof l) < 0 || write(sfd, q->id, l) < 0) - fatal(errno, "writing to %s", addr.sun_path); + disorder_fatal(errno, "writing to %s", addr.sun_path); /* Await the ack */ if (read(sfd, &l, 1) < 0) - fatal(errno, "reading ack from %s", addr.sun_path); + disorder_fatal(errno, "reading ack from %s", addr.sun_path); /* Plumbing */ xdup2(np[0], 0); xdup2(sfd, 1); @@ -436,7 +448,7 @@ static int prepare_child(struct queue_entry *q, log_default == &log_syslog ? "--syslog" : "--no-syslog", "--config", configfile, (char *)0); - fatal(errno, "executing disorder-normalize"); + disorder_fatal(errno, "executing disorder-normalize"); /* End of the great-grandchild of disorderd */ } /* Back in the grandchild of disorderd */ @@ -453,7 +465,7 @@ static int prepare_child(struct queue_entry *q, char buffer[64]; snprintf(buffer, sizeof buffer, "DISORDER_RAW_FD=%d", np[1]); if(putenv(buffer) < 0) - fatal(errno, "error calling putenv"); + disorder_fatal(errno, "error calling putenv"); /* Close all the FDs we don't need */ xclose(np[0]); /* Start the decoder itself */ @@ -464,6 +476,15 @@ static int prepare_child(struct queue_entry *q, return 0; } +/** @brief Kill a player + * @param q Queue entry corresponding to player + */ +static void kill_player(struct queue_entry *q) { + if(q->pid >= 0) + kill(-q->pid, config->signal); + q->killed = config->signal; +} + /** @brief Abandon a queue entry * * Called from c_remove() (but NOT when scratching a track). Only does @@ -479,7 +500,7 @@ void abandon(ev_source attribute((unused)) *ev, if((q->type & DISORDER_PLAYER_TYPEMASK) != DISORDER_PLAYER_RAW) return; /* Not a raw player. */ /* Terminate the player. */ - kill(-q->pid, config->signal); + kill_player(q); /* Cancel the track. */ memset(&sm, 0, sizeof sm); sm.type = SM_CANCEL; @@ -500,7 +521,7 @@ static void chosen_random_track(ev_source *ev, if(!track) return; /* Add the track to the queue */ - q = queue_add(track, 0, WHERE_END, origin_random); + q = queue_add(track, 0, WHERE_END, NULL, origin_random); D(("picked %p (%s) at random", (void *)q, q->track)); queue_write(); /* Maybe a track can now be played */ @@ -583,7 +604,7 @@ void play(ev_source *ev) { } /* It's become the playing track */ playing = q; - time(&playing->played); + xtime(&playing->played); playing->state = playing_started; notify_play(playing->track, playing->submitter); eventlog("playing", playing->track, @@ -595,17 +616,21 @@ void play(ev_source *ev) { * potentially be a just-added random track. */ if(qhead.next != &qhead) prepare(ev, qhead.next); + /* Make sure there is a prepared scratch */ + ensure_next_scratch(ev); break; } } /* Miscelleneous ------------------------------------------------------------ */ +int flag_enabled(const char *s) { + return !s || !strcmp(s, "yes"); +} + /** @brief Return true if play is enabled */ int playing_is_enabled(void) { - const char *s = trackdb_get_global("playing"); - - return !s || !strcmp(s, "yes"); + return flag_enabled(trackdb_get_global("playing")); } /** @brief Enable play */ @@ -617,15 +642,13 @@ void enable_playing(const char *who, ev_source *ev) { } /** @brief Disable play */ -void disable_playing(const char *who) { +void disable_playing(const char *who, ev_source attribute((unused)) *ev) { trackdb_set_global("playing", "no", who); } /** @brief Return true if random play is enabled */ int random_is_enabled(void) { - const char *s = trackdb_get_global("random-play"); - - return !s || !strcmp(s, "yes"); + return flag_enabled(trackdb_get_global("random-play")); } /** @brief Enable random play */ @@ -636,18 +659,33 @@ void enable_random(const char *who, ev_source *ev) { } /** @brief Disable random play */ -void disable_random(const char *who) { +void disable_random(const char *who, ev_source attribute((unused)) *ev) { trackdb_set_global("random-play", "no", who); } /* Scratching --------------------------------------------------------------- */ +/** @brief Track to play next time something is scratched */ +static struct queue_entry *next_scratch; + +/** @brief Ensure there isa prepared scratch */ +static void ensure_next_scratch(ev_source *ev) { + if(next_scratch) /* There's one already */ + return; + if(!config->scratch.n) /* There are no scratches */ + return; + int r = rand() * (double)config->scratch.n / (RAND_MAX + 1.0); + next_scratch = queue_add(config->scratch.s[r], NULL, + WHERE_NOWHERE, NULL, origin_scratch); + if(ev) + prepare(ev, next_scratch); +} + /** @brief Scratch a track - * @param User responsible (or NULL) - * @param Track ID (or NULL for current) + * @param who User responsible (or NULL) + * @param id Track ID (or NULL for current) */ void scratch(const char *who, const char *id) { - struct queue_entry *q; struct speaker_message sm; D(("scratch playing=%p state=%d id=%s playing->id=%s", @@ -666,10 +704,8 @@ void scratch(const char *who, const char *id) { playing->state = playing_scratched; playing->scratched = who ? xstrdup(who) : 0; /* Find the player and kill the whole process group */ - if(playing->pid >= 0) { - D(("kill -%d -%lu", config->signal, (unsigned long)playing->pid)); - kill(-playing->pid, config->signal); - } + if(playing->pid >= 0) + kill_player(playing); /* Tell the speaker, if we think it'll care */ if((playing->type & DISORDER_PLAYER_TYPEMASK) == DISORDER_PLAYER_RAW) { memset(&sm, 0, sizeof sm); @@ -678,14 +714,23 @@ void scratch(const char *who, const char *id) { speaker_send(speaker_fd, &sm); D(("sending SM_CANCEL for %s", playing->id)); } - /* put a scratch track onto the front of the queue (but don't - * bother if playing is disabled) */ - if(playing_is_enabled() && config->scratch.n) { - int r = rand() * (double)config->scratch.n / (RAND_MAX + 1.0); - q = queue_add(config->scratch.s[r], who, WHERE_START, origin_scratch); + /* If playing is enabled then add a scratch to the queue. Having a scratch + * appear in the queue when further play is disabled is weird and + * contradicts implicit assumptions made elsewhere, so we try to avoid + * it. */ + if(playing_is_enabled()) { + /* Try to make sure there is a scratch */ + ensure_next_scratch(NULL); + /* Insert it at the head of the queue */ + if(next_scratch){ + next_scratch->submitter = who; + queue_insert_entry(&qhead, next_scratch); + eventlog_raw("queue", queue_marshall(next_scratch), (const char *)0); + next_scratch = NULL; + } } notify_scratch(playing->track, playing->submitter, who, - time(0) - playing->played); + xtime(0) - playing->played); } } @@ -699,17 +744,13 @@ void quitting(ev_source *ev) { shutting_down = 1; /* Shut down the current player */ if(playing) { - if(playing->pid >= 0) - kill(-playing->pid, config->signal); + kill_player(playing); playing->state = playing_quitting; finished(0); } /* Zap any background decoders that are going */ for(q = qhead.next; q != &qhead; q = q->next) - if(q->pid >= 0) { - D(("kill -%d %lu", config->signal, (unsigned long)q->pid)); - kill(-q->pid, config->signal); - } + kill_player(q); /* Don't need the speaker any more */ ev_fd_cancel(ev, ev_read, speaker_fd); xclose(speaker_fd); @@ -728,14 +769,14 @@ int pause_playing(const char *who) { case DISORDER_PLAYER_STANDALONE: if(!(playing->type & DISORDER_PLAYER_PAUSES)) { default: - error(0, "cannot pause because player is not powerful enough"); + disorder_error(0, "cannot pause because player is not powerful enough"); return -1; } if(play_pause(playing->pl, &played, playing->data)) { - error(0, "player indicates it cannot pause"); + disorder_error(0, "player indicates it cannot pause"); return -1; } - time(&playing->lastpaused); + xtime(&playing->lastpaused); playing->uptopause = played; playing->lastresumed = 0; break; @@ -745,7 +786,8 @@ int pause_playing(const char *who) { speaker_send(speaker_fd, &sm); break; } - if(who) info("paused by %s", who); + if(who) + disorder_info("paused by %s", who); notify_pause(playing->track, who); paused = 1; if(playing->state == playing_started) @@ -763,13 +805,13 @@ void resume_playing(const char *who) { if(!playing) return; switch(playing->type & DISORDER_PLAYER_TYPEMASK) { case DISORDER_PLAYER_STANDALONE: - if(!playing->type & DISORDER_PLAYER_PAUSES) { + if(!(playing->type & DISORDER_PLAYER_PAUSES)) { default: /* Shouldn't happen */ return; } play_resume(playing->pl, playing->data); - time(&playing->lastresumed); + xtime(&playing->lastresumed); break; case DISORDER_PLAYER_RAW: memset(&sm, 0, sizeof sm); @@ -777,7 +819,7 @@ void resume_playing(const char *who) { speaker_send(speaker_fd, &sm); break; } - if(who) info("resumed by %s", who); + if(who) disorder_info("resumed by %s", who); notify_resume(playing->track, who); if(playing->state == playing_paused) playing->state = playing_started;