D(("SM_PLAYING %s %ld", sm.id, sm.data));
playing->sofar = sm.data;
break;
+ case SM_ARRIVED: {
+ /* track ID is now prepared */
+ struct queue_entry *q;
+ for(q = qhead.next; q != &qhead && strcmp(q->id, sm.id); q = q->next)
+ ;
+ if(q && q->preparing) {
+ q->preparing = 0;
+ q->prepared = 1;
+ /* We might be waiting to play the now-prepared track */
+ play(ev);
+ }
+ break;
+ }
default:
disorder_error(0, "unknown speaker message type %d", sm.type);
}
q->state = playing_ok;
break;
}
- /* Regardless we always report and record the status and do cleanup for
- * prefork calls. */
- if(status)
- disorder_error(0, "player for %s %s", q->track, wstat(status));
+ /* Report the status unless we killed it */
+ if(status) {
+ if(!(q->killed && WIFSIGNALED(status) && WTERMSIG(status) == q->killed))
+ disorder_error(0, "player for %s %s", q->track, wstat(status));
+ }
+ /* Clean up any prefork calls */
if(q->type & DISORDER_PLAYER_PREFORK)
play_cleanup(q->pl, q->data);
q->wstat = status;
D(("start %s", q->id));
/* Find the player plugin. */
- if(!(player = find_player(q)) < 0)
+ if(!(player = find_player(q)))
return START_HARDFAIL; /* No player */
if(!(q->pl = open_plugin(player->s[1], 0)))
return START_HARDFAIL;
void attribute((unused)) *bgdata) {
int n;
- /* Wait for a device to clear. This ugliness is now deprecated and will
- * eventually be removed. */
- if(params->waitdevice) {
- ao_initialize();
- if(*params->waitdevice) {
- n = ao_driver_id(params->waitdevice);
- if(n == -1)
- disorder_fatal(0, "invalid libao driver: %s", params->waitdevice);
- } else
- n = ao_default_driver_id();
- /* Make up a format. */
- ao_sample_format format;
- memset(&format, 0, sizeof format);
- format.bits = 8;
- format.rate = 44100;
- format.channels = 1;
- format.byte_format = AO_FMT_NATIVE;
- int retries = 20;
- struct timespec ts;
- ts.tv_sec = 0;
- ts.tv_nsec = 100000000; /* 0.1s */
- ao_device *device;
- while((device = ao_open_live(n, &format, 0)) == 0 && retries-- > 0)
- nanosleep(&ts, 0);
- if(device)
- ao_close(device);
- }
/* Play the track */
play_track(q->pl,
params->argv, params->argc,
if(q->pid >= 0)
return START_OK;
/* If the track is already prepared, do nothing */
- if(q->prepared)
+ if(q->prepared || q->preparing)
return START_OK;
/* Find the player plugin */
- if(!(player = find_player(q)) < 0)
+ if(!(player = find_player(q)))
return START_HARDFAIL; /* No player */
q->pl = open_plugin(player->s[1], 0);
q->type = play_get_type(q->pl);
if((q->type & DISORDER_PLAYER_TYPEMASK) != DISORDER_PLAYER_RAW)
return START_OK; /* Not a raw player */
- const int rc = play_background(ev, player, q, prepare_child, NULL);
+ int rc = play_background(ev, player, q, prepare_child, NULL);
if(rc == START_OK) {
ev_child(ev, q->pid, 0, player_finished, q);
- q->prepared = 1;
+ q->preparing = 1;
+ /* Actually the track is still "in flight" */
+ rc = START_SOFTFAIL;
}
return rc;
}
return 0;
}
+/** @brief Kill a player
+ * @param q Queue entry corresponding to player
+ */
+static void kill_player(struct queue_entry *q) {
+ if(q->pid >= 0)
+ kill(-q->pid, config->signal);
+ q->killed = config->signal;
+}
+
/** @brief Abandon a queue entry
*
* Called from c_remove() (but NOT when scratching a track). Only does
if((q->type & DISORDER_PLAYER_TYPEMASK) != DISORDER_PLAYER_RAW)
return; /* Not a raw player. */
/* Terminate the player. */
- kill(-q->pid, config->signal);
+ kill_player(q);
/* Cancel the track. */
memset(&sm, 0, sizeof sm);
sm.type = SM_CANCEL;
/* Miscelleneous ------------------------------------------------------------ */
+int flag_enabled(const char *s) {
+ return !s || !strcmp(s, "yes");
+}
+
/** @brief Return true if play is enabled */
int playing_is_enabled(void) {
- const char *s = trackdb_get_global("playing");
-
- return !s || !strcmp(s, "yes");
+ return flag_enabled(trackdb_get_global("playing"));
}
/** @brief Enable play */
}
/** @brief Disable play */
-void disable_playing(const char *who) {
+void disable_playing(const char *who, ev_source attribute((unused)) *ev) {
trackdb_set_global("playing", "no", who);
}
/** @brief Return true if random play is enabled */
int random_is_enabled(void) {
- const char *s = trackdb_get_global("random-play");
-
- return !s || !strcmp(s, "yes");
+ return flag_enabled(trackdb_get_global("random-play"));
}
/** @brief Enable random play */
}
/** @brief Disable random play */
-void disable_random(const char *who) {
+void disable_random(const char *who, ev_source attribute((unused)) *ev) {
trackdb_set_global("random-play", "no", who);
}
playing->state = playing_scratched;
playing->scratched = who ? xstrdup(who) : 0;
/* Find the player and kill the whole process group */
- if(playing->pid >= 0) {
- D(("kill -%d -%lu", config->signal, (unsigned long)playing->pid));
- kill(-playing->pid, config->signal);
- }
+ if(playing->pid >= 0)
+ kill_player(playing);
/* Tell the speaker, if we think it'll care */
if((playing->type & DISORDER_PLAYER_TYPEMASK) == DISORDER_PLAYER_RAW) {
memset(&sm, 0, sizeof sm);
speaker_send(speaker_fd, &sm);
D(("sending SM_CANCEL for %s", playing->id));
}
- /* Try to make sure there is a scratch */
- ensure_next_scratch(NULL);
- /* Insert it at the head of the queue */
- if(next_scratch){
- next_scratch->submitter = who;
- queue_insert_entry(&qhead, next_scratch);
- eventlog_raw("queue", queue_marshall(next_scratch), (const char *)0);
- next_scratch = NULL;
+ /* If playing is enabled then add a scratch to the queue. Having a scratch
+ * appear in the queue when further play is disabled is weird and
+ * contradicts implicit assumptions made elsewhere, so we try to avoid
+ * it. */
+ if(playing_is_enabled()) {
+ /* Try to make sure there is a scratch */
+ ensure_next_scratch(NULL);
+ /* Insert it at the head of the queue */
+ if(next_scratch){
+ next_scratch->submitter = who;
+ queue_insert_entry(&qhead, next_scratch);
+ eventlog_raw("queue", queue_marshall(next_scratch), (const char *)0);
+ next_scratch = NULL;
+ }
}
notify_scratch(playing->track, playing->submitter, who,
xtime(0) - playing->played);
shutting_down = 1;
/* Shut down the current player */
if(playing) {
- if(playing->pid >= 0)
- kill(-playing->pid, config->signal);
+ kill_player(playing);
playing->state = playing_quitting;
finished(0);
}
/* Zap any background decoders that are going */
for(q = qhead.next; q != &qhead; q = q->next)
- if(q->pid >= 0) {
- D(("kill -%d %lu", config->signal, (unsigned long)q->pid));
- kill(-q->pid, config->signal);
- }
+ kill_player(q);
/* Don't need the speaker any more */
ev_fd_cancel(ev, ev_read, speaker_fd);
xclose(speaker_fd);
~mdw / disorder / blobdiff