/*
* This file is part of DisOrder.
- * Copyright (C) 2004-2010 Richard Kettlewell
+ * Copyright (C) 2004-13 Richard Kettlewell
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
#include "common.h"
#include <sys/types.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-#include <sys/un.h>
-#include <unistd.h>
+#if HAVE_SYS_SOCKET_H
+# include <sys/socket.h>
+#endif
+#if HAVE_NETINET_IN_H
+# include <netinet/in.h>
+#endif
+#if HAVE_SYS_UN_H
+# include <sys/un.h>
+#endif
+#if HAVE_UNISTD_H
+# include <unistd.h>
+#endif
#include <errno.h>
-#include <netdb.h>
-#include <pcre.h>
+#if HAVE_NETDB_H
+# include <netdb.h>
+#endif
#include "log.h"
#include "mem.h"
#include "authhash.h"
#include "client-common.h"
#include "rights.h"
-#include "trackdb.h"
#include "kvp.h"
+#include "socketio.h"
/** @brief Client handle contents */
struct disorder_client {
/** @brief Stream to read from */
- FILE *fpin;
+ struct source *input;
/** @brief Stream to write to */
- FILE *fpout;
+ struct sink *output;
/** @brief Peer description */
char *ident;
/** @brief Username */
int verbose;
/** @brief Last error string */
const char *last;
+ /** @brief Address family */
+ int family;
+ /** @brief True if open */
+ int open;
+ /** @brief Socket I/O context */
+ struct socketio sio;
+ /** @brief Whether to try to open a privileged connection */
+ int trypriv;
};
/** @brief Create a new client
disorder_client *c = xmalloc(sizeof (struct disorder_client));
c->verbose = verbose;
+ c->family = -1;
+ c->trypriv = 1;
return c;
}
+/** @brief Don't try to make a privileged connection
+ * @param c Client
+ *
+ * You must call this before any of the connection functions (e.g.,
+ * disorder_connect(), disorder_connect_user()), if at all.
+ */
+void disorder_force_unpriv(disorder_client *c) {
+ assert(!c->open);
+ c->trypriv = 0;
+}
+
+/** @brief Determine the local socket address of this client */
+int disorder_client_sockname(disorder_client *c,
+ struct sockaddr *sa, socklen_t *len_inout) {
+ int rc;
+ if((rc = getsockname(c->sio.sd, sa, len_inout)))
+ disorder_error(errno, "failed to read client socket name");
+ return rc;
+}
+
+/** @brief Determine the remote peer address for this client */
+int disorder_client_peername(disorder_client *c,
+ struct sockaddr *sa, socklen_t *len_inout) {
+ int rc;
+ if((rc = getpeername(c->sio.sd, sa, len_inout)))
+ disorder_error(errno, "failed to read client socket name");
+ return rc;
+}
+
/** @brief Read a response line
* @param c Client
* @param rp Where to store response, or NULL (UTF-8)
*/
static int response(disorder_client *c, char **rp) {
char *r;
+ char errbuf[1024];
- if(inputline(c->ident, c->fpin, &r, '\n')) {
- byte_xasprintf((char **)&c->last, "input error: %s", strerror(errno));
+ if(inputlines(c->ident, c->input, &r, '\n')) {
+ byte_xasprintf((char **)&c->last, "input error: %s",
+ format_error(c->input->eclass, source_err(c->input), errbuf, sizeof errbuf));
return -1;
}
D(("response: %s", r));
char **body = NULL;
int nbody = 0;
int has_body = 0;
+ char errbuf[1024];
- if(!c->fpout) {
+ if(!c->open) {
c->last = "not connected";
disorder_error(0, "not connected to server");
return -1;
} else if(arg == disorder__list) {
char **list = va_arg(ap, char **);
int nlist = va_arg(ap, int);
+ int n;
if(nlist < 0) {
for(nlist = 0; list[nlist]; ++nlist)
;
}
- for(int n = 0; n < nlist; ++n) {
+ for(n = 0; n < nlist; ++n) {
dynstr_append(&d, ' ');
dynstr_append_string(&d, quoteutf8(arg));
}
} else if(arg == disorder__integer) {
long n = va_arg(ap, long);
char buffer[16];
- snprintf(buffer, sizeof buffer, "%ld", n);
+ byte_snprintf(buffer, sizeof buffer, "%ld", n);
dynstr_append(&d, ' ');
dynstr_append_string(&d, buffer);
} else if(arg == disorder__time) {
time_t n = va_arg(ap, time_t);
char buffer[16];
- snprintf(buffer, sizeof buffer, "%lld", (long long)n);
+ byte_snprintf(buffer, sizeof buffer, "%lld", (long long)n);
dynstr_append(&d, ' ');
dynstr_append_string(&d, buffer);
} else {
dynstr_append(&d, '\n');
dynstr_terminate(&d);
D(("command: %s", d.vec));
- if(fputs(d.vec, c->fpout) < 0)
+ if(sink_write(c->output, d.vec, d.nvec) < 0)
goto write_error;
xfree(d.vec);
if(has_body) {
+ int n;
if(nbody < 0)
for(nbody = 0; body[nbody]; ++nbody)
;
- for(int n = 0; n < nbody; ++n) {
+ for(n = 0; n < nbody; ++n) {
if(body[n][0] == '.')
- if(fputc('.', c->fpout) < 0)
+ if(sink_writec(c->output, '.') < 0)
goto write_error;
- if(fputs(body[n], c->fpout) < 0)
+ if(sink_writes(c->output, body[n]) < 0)
goto write_error;
- if(fputc('\n', c->fpout) < 0)
+ if(sink_writec(c->output, '\n') < 0)
goto write_error;
}
- if(fputs(".\n", c->fpout) < 0)
+ if(sink_writes(c->output, ".\n") < 0)
goto write_error;
}
- if(fflush(c->fpout))
+ if(sink_flush(c->output))
goto write_error;
}
return check_response(c, rp);
write_error:
- byte_xasprintf((char **)&c->last, "write error: %s", strerror(errno));
- disorder_error(errno, "error writing to %s", c->ident);
+ byte_xasprintf((char **)&c->last, "write error: %s",
+ format_error(c->output->eclass, sink_err(c->output), errbuf, sizeof errbuf));
+ disorder_error(0, "%s: %s", c->ident, c->last);
return -1;
}
const char *username,
const char *password,
const char *cookie) {
- int fd = -1, fd2 = -1, nrvec = 0, rc;
+ SOCKET sd = INVALID_SOCKET;
+ int nrvec = 0, rc;
unsigned char *nonce = NULL;
size_t nl;
char *res = NULL;
const char *protocol, *algorithm, *challenge;
struct sockaddr *sa = NULL;
socklen_t salen;
+ char errbuf[1024];
- if((salen = find_server(conf, &sa, &c->ident)) == (socklen_t)-1)
+ if((salen = disorder_find_server(conf,
+ (c->trypriv ? 0 : DISORDER_FS_NOTPRIV),
+ &sa, &c->ident)) == (socklen_t)-1)
return -1;
- c->fpin = c->fpout = 0;
- if((fd = socket(sa->sa_family, SOCK_STREAM, 0)) < 0) {
- byte_xasprintf((char **)&c->last, "socket: %s", strerror(errno));
- disorder_error(errno, "error calling socket");
+ c->input = 0;
+ c->output = 0;
+ if((sd = socket(sa->sa_family, SOCK_STREAM, 0)) < 0) {
+ byte_xasprintf((char **)&c->last, "socket: %s",
+ format_error(ec_socket, socket_error(), errbuf, sizeof errbuf));
+ disorder_error(0, "%s", c->last);
return -1;
}
- if(connect(fd, sa, salen) < 0) {
- byte_xasprintf((char **)&c->last, "connect: %s", strerror(errno));
- disorder_error(errno, "error calling connect");
- goto error;
- }
- if((fd2 = dup(fd)) < 0) {
- byte_xasprintf((char **)&c->last, "dup: %s", strerror(errno));
- disorder_error(errno, "error calling dup");
- goto error;
- }
- if(!(c->fpin = fdopen(fd, "rb"))) {
- byte_xasprintf((char **)&c->last, "fdopen: %s", strerror(errno));
- disorder_error(errno, "error calling fdopen");
- goto error;
- }
- fd = -1;
- if(!(c->fpout = fdopen(fd2, "wb"))) {
- byte_xasprintf((char **)&c->last, "fdopen: %s", strerror(errno));
- disorder_error(errno, "error calling fdopen");
+ c->family = sa->sa_family;
+ if(connect(sd, sa, salen) < 0) {
+ byte_xasprintf((char **)&c->last, "connect: %s",
+ format_error(ec_socket, socket_error(), errbuf, sizeof errbuf));
+ disorder_error(0, "%s", c->last);
goto error;
}
- fd2 = -1;
+ socketio_init(&c->sio, sd);
+ c->open = 1;
+ sd = INVALID_SOCKET;
+ c->output = sink_socketio(&c->sio);
+ c->input = source_socketio(&c->sio);
if((rc = disorder_simple(c, &r, 0, (const char *)0)))
goto error_rc;
if(!(rvec = split(r, &nrvec, SPLIT_QUOTES, 0, 0)))
error:
rc = -1;
error_rc:
- if(c->fpin) {
- fclose(c->fpin);
- c->fpin = 0;
- }
- if(c->fpout) {
- fclose(c->fpout);
- c->fpout = 0;
- }
- if(fd2 != -1) close(fd2);
- if(fd != -1) close(fd);
+ xfree(c->output);
+ c->output = NULL;
+ xfree(c->input);
+ c->input = NULL;
+ if(c->open) { socketio_close(&c->sio); c->open = 0; }
+ if(sd != INVALID_SOCKET) closesocket(sd);
return rc;
}
return -1;
}
password = config->password;
- /* Maybe we can read the database */
- if(!password && trackdb_readable()) {
- trackdb_init(TRACKDB_NO_RECOVER|TRACKDB_NO_UPGRADE);
- trackdb_open(TRACKDB_READ_ONLY);
- password = trackdb_get_password(username);
- trackdb_close();
- }
+ /* If we're connecting as 'root' guess that we're the system root
+ * user (or the jukebox user), both of which can use the privileged
+ * socket. They can also furtle with the db directly: that is why
+ * privileged socket does not represent a privilege escalation. */
+ if(!password
+ && !strcmp(username, "root"))
+ password = "anything will do for root";
if(!password) {
/* Oh well */
c->last = "no password";
*
* If @p cookie is NULL or does not work then we attempt to log in as
* guest instead (so when the cookie expires only an extra round trip
- * is needed rathre than a complete new login).
+ * is needed rather than a complete new login).
*/
int disorder_connect_cookie(disorder_client *c,
const char *cookie) {
int disorder_close(disorder_client *c) {
int ret = 0;
- if(c->fpin) {
- if(fclose(c->fpin) < 0) {
- byte_xasprintf((char **)&c->last, "fclose: %s", strerror(errno));
- disorder_error(errno, "error calling fclose");
- ret = -1;
- }
- c->fpin = 0;
- }
- if(c->fpout) {
- if(fclose(c->fpout) < 0) {
- byte_xasprintf((char **)&c->last, "fclose: %s", strerror(errno));
- disorder_error(errno, "error calling fclose");
- ret = -1;
- }
- c->fpout = 0;
- }
+ if(c->open)
+ socketio_close(&c->sio);
+ xfree(c->output);
+ c->output = NULL;
+ xfree(c->input);
+ c->input = NULL;
xfree(c->ident);
c->ident = 0;
xfree(c->user);
struct queue_entry **qp) {
struct queue_entry *qh, **qt = &qh, *q;
char *l;
+ char errbuf[1024];
- while(inputline(c->ident, c->fpin, &l, '\n') >= 0) {
+ while(inputlines(c->ident, c->input, &l, '\n') >= 0) {
if(!strcmp(l, ".")) {
*qt = 0;
*qp = qh;
}
xfree(l);
}
- if(ferror(c->fpin)) {
- byte_xasprintf((char **)&c->last, "input error: %s", strerror(errno));
- disorder_error(errno, "error reading %s", c->ident);
+ if(source_err(c->input)) {
+ byte_xasprintf((char **)&c->last, "input error: %s",
+ format_error(c->input->eclass, source_err(c->input), errbuf, sizeof errbuf));
} else {
c->last = "input error: unexpected EOF";
- disorder_error(0, "error reading %s: unexpected EOF", c->ident);
}
+ disorder_error(0, "%s: %s", c->ident, c->last);
return -1;
}
static int readlist(disorder_client *c, char ***vecp, int *nvecp) {
char *l;
struct vector v;
+ char errbuf[1024];
vector_init(&v);
- while(inputline(c->ident, c->fpin, &l, '\n') >= 0) {
+ while(inputlines(c->ident, c->input, &l, '\n') >= 0) {
if(!strcmp(l, ".")) {
vector_terminate(&v);
if(nvecp)
vector_append(&v, xstrdup(l + (*l == '.')));
xfree(l);
}
- if(ferror(c->fpin)) {
- byte_xasprintf((char **)&c->last, "input error: %s", strerror(errno));
- disorder_error(errno, "error reading %s", c->ident);
+ if(source_err(c->input)) {
+ byte_xasprintf((char **)&c->last, "input error: %s",
+ format_error(c->input->eclass, source_err(c->input), errbuf, sizeof errbuf));
} else {
c->last = "input error: unexpxected EOF";
- disorder_error(0, "error reading %s: unexpected EOF", c->ident);
}
+ disorder_error(0, "%s: %s", c->ident, c->last);
return -1;
}
return 0;
}
+#if _WIN32
+# define boolean bodge_boolean
+#endif
+
/** @brief Parse a boolean response
* @param cmd Command for use in error messsage
* @param value Result from server
int disorder_log(disorder_client *c, struct sink *s) {
char *l;
int rc;
+ char errbuf[1024];
if((rc = disorder_simple(c, 0, "log", (char *)0)))
return rc;
- while(inputline(c->ident, c->fpin, &l, '\n') >= 0 && strcmp(l, "."))
+ while(inputlines(c->ident, c->input, &l, '\n') >= 0 && strcmp(l, "."))
if(sink_printf(s, "%s\n", l) < 0) return -1;
- if(ferror(c->fpin) || feof(c->fpin)) {
+ if(source_err(c->input)) {
byte_xasprintf((char **)&c->last, "input error: %s",
- ferror(c->fpin) ? strerror(errno) : "unexpxected EOF");
+ format_error(c->input->eclass, source_err(c->input), errbuf, sizeof errbuf));
+ return -1;
+ } else if(source_eof(c->input)) {
+ byte_xasprintf((char **)&c->last, "input error: unexpected EOF");
return -1;
}
+
return 0;
}
~mdw / disorder / blobdiff