More graceful handling of test failure; the exception is now reported

[disorder] / tests / play.py

diff --git a/tests/play.py b/tests/play.py
index 92bb6649dfc5c248cd0f3f2d71616cbedf148600..abf1b38b97495e6f48aaa13714924b6016c617fa 100755 (executable)
--- a/tests/play.py
+++ b/tests/play.py
@@ -1,31 +1,35 @@
 #! /usr/bin/env python
 #
 # This file is part of DisOrder.
-# Copyright (C) 2007 Richard Kettlewell
+# Copyright (C) 2007, 2008 Richard Kettlewell
 #
-# This program is free software; you can redistribute it and/or modify
+# This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
+# the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
 #
-# This program is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# General Public License for more details.
-#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+# 
 # You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
-# USA
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
-import dtest,time,disorder,re
+import dtest,time,disorder,re,sys
 
 def test():
     """Play some tracks"""
     dtest.start_daemon()
+    dtest.create_user()
+    dtest.rescan()                      # ensure all files are scanned
     c = disorder.client()
+    c.random_disable()
+    assert c.random_enabled() == False
     track = u"%s/Joe Bloggs/First Album/02:Second track.ogg" % dtest.tracks
-    print "adding track to queue"
+    print " adding track to queue"
+    c.disable()
+    assert c.enabled() == False
     c.play(track)
     print " checking track turned up in queue"
     q = c.queue()
@@ -35,13 +39,19 @@ def test():
     assert t['submitter'] == u'fred', "check queue submitter"
     i = t['id']
     print " waiting for track"
+    c.enable()
+    assert c.enabled() == True
     p = c.playing()
     r = c.recent()
+    limit = 60
     while not((p is not None and p['id'] == i)
-              or (len(filter(lambda t: t['track'] == track and 'submitter' in t, r)) > 0)):
+              or (len(filter(lambda t: t['track'] == track
+                             and 'submitter' in t, r)) > 0)) and limit > 0:
         time.sleep(1)
         p = c.playing()
         r = c.recent()
+        limit -= 1
+    assert limit > 0, "check track did complete in a reasonable time"
     print " checking track turned up in recent list"
     while (p is not None and p['id'] == i):
         time.sleep(1)
@@ -51,25 +61,53 @@ def test():
     assert len(ts) == 1, "check track appears exactly once in recent"
     t = ts[0]
     assert t['submitter'] == u'fred', "check recent entry submitter"
-    print " disabling play"
-    c.disable()
-    print " scratching current track"
-    p = c.playing()
-    i = p['id']
-    c.scratch(i)
-    print " checking scratched track turned up in recent list"
-    while (p is not None and p['id'] == i):
-        time.sleep(1)
+
+    print " testing scratches"
+    retry = False
+    scratchlimit = 5
+    while scratchlimit > 0:
+        scratchlimit -= 1
+        c.disable()
+        print " starting a track"
+        c.play(track)
+        c.enable()
         p = c.playing()
-    r = c.recent()
-    ts = filter(lambda t: t['id'] == i, r)
-    assert len(ts) == 1, "check scratched track appears exactly once in recent"
-    assert ts[0]['state'] == 'scratched', "checking track scratched"
+        if p is None:
+            print " track played too quickly, trying again..."
+            continue
+        print " scratching track"
+        i = p['id']
+        c.scratch(i)
+        print " waiting for track to finish"
+        p = c.playing()
+        limit = 60
+        while (p is not None and p['id'] == i) and limit > 0:
+            time.sleep(1)
+            p = c.playing()
+            limit -= 1
+        assert limit > 0, "check track finishes in a reasonable period"
+        print " checking scratched track turned up in recent list"
+        r = c.recent()
+        ts = filter(lambda t: t['id'] == i, r)
+        assert len(ts) == 1, "check scratched track appears exactly once in recent"
+        if ts[0]['state'] == 'ok':
+            print " track played too quickly, trying again..."
+            continue
+        assert ts[0]['state'] == 'scratched', "checking track scratched"
+        break
+    if scratchlimit == 0:
+        # TODO this is really not a great approach!
+        print " didn't complete in a reasonable time"
+        sys.exit(77)
     print " waiting for scratch to complete"
-    while (p is not None and p['state'] == 'isscratch'):
+    p = c.recent()
+    while p is not None:
         time.sleep(1)
         p = c.playing()
     assert p is None, "checking nothing is playing"
+    assert c.enabled() == True
+    c.random_enable()
+    assert c.random_enabled() == True
 
 if __name__ == '__main__':
     dtest.run()