exercise the C client a bit from tests

[disorder] / lib / eventlog.c

diff --git a/lib/eventlog.c b/lib/eventlog.c
index c374e4adc30340f9e8a028a6ae3a0f08033c6813..1d1fb8b621c65505aa470ba6c954e268d0b3f2a5 100644 (file)
--- a/lib/eventlog.c
+++ b/lib/eventlog.c
@@ -48,7 +48,7 @@ void eventlog_remove(struct eventlog_output *lo) {
 }
 
 static void veventlog(const char *keyword, const char *raw, va_list ap) {
-  struct eventlog_output *p;
+  struct eventlog_output *p, *pnext;
   struct dynstr d;
   const char *param;
 
@@ -63,8 +63,12 @@ static void veventlog(const char *keyword, const char *raw, va_list ap) {
     dynstr_append_string(&d, raw);
   }
   dynstr_terminate(&d);
-  for(p = outputs; p; p = p->next)
+  for(p = outputs; p; p = pnext) {
+    /* We must be able to cope with eventlog_remove() being called from inside
+     * the callback */
+    pnext = p->next;
     p->fn(d.vec, p->user);
+  }
 }
 
 void eventlog_raw(const char *keyword, const char *raw, ...) {
@@ -90,4 +94,3 @@ comment-column:40
 fill-column:79
 End:
 */
-/* arch-tag:Io9E4IlqSMg7Kum3sq080Q */