Avoid play.py looping indefinitely.

[disorder] / tests / play.py

diff --git a/tests/play.py b/tests/play.py
index ce5cbb1c6d05aac0fc4f0b5e73d83cb02f65d326..c298ce514656403f6133de31f13b38e3abcc2fec 100755 (executable)
--- a/tests/play.py
+++ b/tests/play.py
@@ -18,12 +18,13 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
 # USA
 #
-import dtest,time,disorder,re
+import dtest,time,disorder,re,sys
 
 def test():
     """Play some tracks"""
     dtest.start_daemon()
     dtest.create_user()
+    dtest.rescan()                      # ensure all files are scanned
     c = disorder.client()
     c.random_disable()
     assert c.random_enabled() == False
@@ -44,11 +45,15 @@ def test():
     assert c.enabled() == True
     p = c.playing()
     r = c.recent()
+    limit = 60
     while not((p is not None and p['id'] == i)
-              or (len(filter(lambda t: t['track'] == track and 'submitter' in t, r)) > 0)):
+              or (len(filter(lambda t: t['track'] == track
+                             and 'submitter' in t, r)) > 0)) and limit > 0:
         time.sleep(1)
         p = c.playing()
         r = c.recent()
+        limit -= 1
+    assert limit > 0, "check track did complete in a reasonable time"
     print " checking track turned up in recent list"
     while (p is not None and p['id'] == i):
         time.sleep(1)
@@ -61,7 +66,9 @@ def test():
 
     print " testing scratches"
     retry = False
-    while True:
+    scratchlimit = 5
+    while scratchlimit > 0:
+        scratchlimit -= 1
         c.disable()
         print " starting a track"
         c.play(track)
@@ -75,9 +82,12 @@ def test():
         c.scratch(i)
         print " waiting for track to finish"
         p = c.playing()
-        while (p is not None and p['id'] == i):
+        limit = 60
+        while (p is not None and p['id'] == i) and limit > 0:
             time.sleep(1)
             p = c.playing()
+            limit -= 1
+        assert limit > 0, "check track finishes in a reasonable period"
         print " checking scratched track turned up in recent list"
         r = c.recent()
         ts = filter(lambda t: t['id'] == i, r)
@@ -87,6 +97,10 @@ def test():
             continue
         assert ts[0]['state'] == 'scratched', "checking track scratched"
         break
+    if scratchlimit == 0:
+        # TODO this is really not a great approach!
+        print " didn't complete in a reasonable time"
+        sys.exit(77)
     print " waiting for scratch to complete"
     p = c.recent()
     while p is not None: