From 505f2736ba9408a76168dd818f7c0cb60d7cb45d Mon Sep 17 00:00:00 2001 Message-Id: <505f2736ba9408a76168dd818f7c0cb60d7cb45d.1714699938.git.mdw@distorted.org.uk> From: Mark Wooding Date: Wed, 24 Sep 1997 09:48:45 +0000 Subject: [PATCH] Fix (scary) overrun bug in group allocation stuff. Organization: Straylight/Edgeware From: mdw --- src/become.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/become.c b/src/become.c index d94e3c2..e73f5da 100644 --- a/src/become.c +++ b/src/become.c @@ -1,6 +1,6 @@ /* -*-c-*- * - * $Id: become.c,v 1.10 1997/09/17 10:14:10 mdw Exp $ + * $Id: become.c,v 1.11 1997/09/24 09:48:45 mdw Exp $ * * Main code for `become' * @@ -29,7 +29,10 @@ /*----- Revision history --------------------------------------------------* * * $Log: become.c,v $ - * Revision 1.10 1997/09/17 10:14:10 mdw + * Revision 1.11 1997/09/24 09:48:45 mdw + * Fix (scary) overrun bug in group allocation stuff. + * + * Revision 1.10 1997/09/17 10:14:10 mdw * Fix a typo. Support service names in `--port' option. * * Revision 1.9 1997/09/10 10:28:05 mdw @@ -304,8 +307,8 @@ static int bc__addGroups(gid_t *g, int *png, const gid_t *a, int na) /* --- See if there's room for more --- */ - if (ng > NGROUPS_MAX) { - moan("too many groups (system limit exceeded -- some have been lost"); + if (ng >= NGROUPS_MAX) { + moan("too many groups (system limit exceeded) -- some have been lost"); *png = ng; return (-1); } -- [mdw]