break out gen_local_part_alphanum

[d.git] / service

diff --git a/service b/service
index 1d64c5bd0708da373bddcde8640e69d9f4ff92da..3e1197d141b6b21dc4b768e4aaf7b05465ea3e85 100755 (executable)
--- a/service
+++ b/service
@@ -41,6 +41,7 @@ our $dom;
 our $user;
 our $priv;
 our $showcomment;
+our $genmethod = 'alphanum';
 
 sub nextarg () {
     die "too few arguments\n" unless @ARGV;
@@ -73,14 +74,19 @@ sub isdisabled ($) {
     return !!$row;
 }
 
-sub prow ($) {
-    my ($row) = @_;
-    my $u = $row->{'user'};
+sub puser ($) {
+    my ($u) = @_;
     our $last_u;
     if (!defined $last_u or $last_u ne $u) {
        print "# user $u ".(isdisabled($u) ? 'disabled' : 'enabled')."\n";
        $last_u = $u;
     }
+}
+
+sub prow ($) {
+    my ($row) = @_;
+    my $u = $row->{'user'};
+    puser($u);
     my $pa = $row->{'localpart'};
     $pa .= '@'.$dom if defined $dom;
     if (length $row->{'redirect'}) {
@@ -155,16 +161,21 @@ sub local_part_inuse ($) {
     return !!$row;
 }
 
+sub gen_local_part_alphanum {
+    my $s = chr(ord('a')+goodrand(26));
+    while (length $s < $randlength) {
+       my $v = goodrand(36);
+       $s .= chr($v < 26
+                 ? ord('a')+($v)
+                 : ord('0')+($v-26));
+    }
+    return $s;
+}
+
 sub generate_local_part () {
     my $s;
     for (;;) {
-       $s = chr(ord('a')+goodrand(26));
-       while (length $s < $randlength) {
-           my $v = goodrand(36);
-           $s .= chr($v < 26
-                     ? ord('a')+($v)
-                     : ord('0')+($v-26));
-       }
+       { no strict qw(refs); $s = &{"gen_local_part_$genmethod"}; }
 #      print STDERR "$s\n";
        last if !local_part_inuse($s);
     }
@@ -195,6 +206,7 @@ sub action_choose {
     my $template = rhsargs({'redirect'=>$user, 'comment'=>''});
     $template->{'user'} = $user;
     prepare_create();
+    puser($user);
     my %s;
     while (keys %s < 10) {
        my $s = generate_local_part();
@@ -204,7 +216,7 @@ sub action_choose {
        print "\n" or die $!;
        $s{$s} = 1;
     }
-    print "# enter addresses or local parts to create,".
+    print "# ready - enter addrs or local-parts to create,".
        " then \`.' on a line by itself\n"
        or die $!;
 
@@ -225,7 +237,7 @@ sub action_choose {
            prow($newrow);
        } else {
            $dbh->rollback();
-           print "!error: $@" or die $!;
+           print "! error: $@" or die $!;
        }
     }
 }