From b91db65a6fc5ea2b36bfd46bd3555f4ee77f46d5 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sat, 7 Dec 2019 14:49:50 +0000 Subject: [PATCH] privcache: Regularise error handling in missing defhash case Now it is clearer to see that we don't leak sigpriv; Signed-off-by: Ian Jackson --- privcache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/privcache.c b/privcache.c index c01af9d..c8a9a7f 100644 --- a/privcache.c +++ b/privcache.c @@ -118,8 +118,6 @@ static struct sigprivkey_if *uncached_load_file( slilog(log,M_ERR, "private key %s requires `hash' config key for privcache to load", path); - sigpriv->dispose(sigpriv->st); - sigpriv=0; goto error_out; } sigpriv->sethash(sigpriv->st,defhash); @@ -130,6 +128,7 @@ static struct sigprivkey_if *uncached_load_file( return ok ? sigpriv : 0; error_out: + if (sigpriv) sigpriv->dispose(sigpriv->st); ok=False; goto out; } -- 2.30.2