X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=secnet.git;a=blobdiff_plain;f=udp.c;h=706e07786d7dc76b99f2aaaa1677bc8832067cfb;hp=8780c7e9f22f29db72d6918e38752c3dedfec176;hb=328ae477c72b63616f28de2ff3ead9bf8d4752ba;hpb=f7af31926b95660b98177fb4fd48c72edf32944d

diff --git a/udp.c b/udp.c
index 8780c7e..706e077 100644
--- a/udp.c
+++ b/udp.c
@@ -72,6 +72,34 @@ static int udp_socks_beforepoll(void *state, struct pollfd *fds, int *nfds_io,
     return 0;
 }
 
+const char *af_name(int af)
+{
+    switch (af) {
+    case AF_INET6: return "IPv6";
+    case AF_INET:  return "IPv4";
+    case 0:        return "(any)";
+    default: abort();
+    }
+}
+
+void udp_sock_experienced(struct log_if *lg, struct udpcommon *uc,
+			  const char *socksdesc, struct udpsock *us,
+			  bool_t recvsend, int af,
+			  int r, int errnoval)
+{
+    bool_t success=r>=0;
+    if (us->experienced[recvsend][af][success]++)
+	return;
+    lg_perror(lg, uc->cc.cl.description, &uc->cc.loc,
+	      success ? M_INFO : M_WARNING,
+	      success ? 0 : errnoval,
+	      "%s %s experiencing some %s %s%s%s",
+	      socksdesc,iaddr_to_string(&us->addr),
+	      success?"success":"trouble",
+	      recvsend?"transmitting":"receiving",
+	      af?" ":"", af?af_name(af):"");
+}
+
 static void udp_socks_afterpoll(void *state, struct pollfd *fds, int nfds)
 {
     struct udpsocks *socks=state;
@@ -85,10 +113,11 @@ static void udp_socks_afterpoll(void *state, struct pollfd *fds, int nfds)
     struct commcommon *cc=&uc->cc;
 
     for (i=0; i<socks->n_socks; i++) {
+	struct udpsock *us=&socks->socks[i];
 	if (i>=nfds) continue;
 	if (!(fds[i].revents & POLLIN)) continue;
-	assert(fds[i].fd == socks->socks[i].fd);
-	int fd=socks->socks[i].fd;
+	assert(fds[i].fd == us->fd);
+	int fd=us->fd;
 	do {
 	    fromlen=sizeof(from);
 	    BUF_ASSERT_FREE(cc->rbuf);
@@ -134,7 +163,9 @@ static void udp_socks_afterpoll(void *state, struct pollfd *fds, int nfds)
 		    BUF_FREE(cc->rbuf);
 		}
 		BUF_ASSERT_FREE(cc->rbuf);
-	    } else {
+	    } else { /* rv<=0 */
+		if (errno!=EINTR && !iswouldblock(errno))
+		    udp_sock_experienced(0,uc, "socket",us, 0,0, rv,errno);
 		BUF_FREE(cc->rbuf);
 	    }
 	} while (rv>=0);
@@ -150,6 +181,7 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf,
     uint8_t *sa;
 
     if (uc->use_proxy) {
+	struct udpsock *us=&socks->socks[0];
 	sa=buf_prepend(buf,8);
 	if (dest->ia.sa.sa_family != AF_INET) {
 	    Message(M_INFO,
@@ -160,18 +192,22 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf,
 	memcpy(sa,&dest->ia.sin.sin_addr,4);
 	memset(sa+4,0,4);
 	memcpy(sa+6,&dest->ia.sin.sin_port,2);
-	sendto(socks->socks[0].fd,sa,buf->size+8,0,&uc->proxy.sa,
+	int r=sendto(us->fd,sa,buf->size+8,0,&uc->proxy.sa,
 	       iaddr_socklen(&uc->proxy));
+	udp_sock_experienced(0,uc, "proxy",us, 1,0, r,errno);
 	buf_unprepend(buf,8);
     } else {
 	int i,r;
 	bool_t allunsupported=True;
+	int af=dest->ia.sa.sa_family;
 	for (i=0; i<socks->n_socks; i++) {
-	    if (dest->ia.sa.sa_family != socks->socks[i].addr.sa.sa_family)
+	    struct udpsock *us=&socks->socks[i];
+	    if (us->addr.sa.sa_family != af)
 		/* no point even trying */
 		continue;
-	    r=sendto(socks->socks[i].fd, buf->start, buf->size, 0,
+	    r=sendto(us->fd, buf->start, buf->size, 0,
 		     &dest->ia.sa, iaddr_socklen(&dest->ia));
+	    udp_sock_experienced(0,uc, "socket",us, 1,af, r,errno);
 	    if (r>=0) return True;
 	    if (!(errno==EAFNOSUPPORT || errno==ENETUNREACH))
 		/* who knows what that error means? */
@@ -183,19 +219,31 @@ static bool_t udp_sendmsg(void *commst, struct buffer_if *buf,
     return True;
 }
 
-void udp_make_socket(struct udpcommon *uc, struct udpsock *us)
+void udp_destroy_socket(struct udpcommon *uc, struct udpsock *us)
+{
+    if (us->fd>=0) {
+	close(us->fd);
+	us->fd=-1;
+    }
+}
+
+bool_t udp_make_socket(struct udpcommon *uc, struct udpsock *us,
+		       int failmsgclass)
 {
     const union iaddr *addr=&us->addr;
     struct commcommon *cc=&uc->cc;
+    us->fd=-1;
+
+#define FAIL_LG 0, cc->cl.description, &cc->loc, failmsgclass
+#define FAIL(...) do{						\
+        lg_perror(FAIL_LG,errno,__VA_ARGS__);	\
+	goto failed;						\
+    }while(0)
 
+    FILLZERO(us->experienced);
     us->fd=socket(addr->sa.sa_family, SOCK_DGRAM, IPPROTO_UDP);
-    if (us->fd<0) {
-	fatal_perror("udp (%s:%d): socket",cc->loc.file,cc->loc.line);
-    }
-    if (fcntl(us->fd, F_SETFL, fcntl(us->fd, F_GETFL)|O_NONBLOCK)==-1) {
-	fatal_perror("udp (%s:%d): fcntl(set O_NONBLOCK)",
-		     cc->loc.file,cc->loc.line);
-    }
+    if (us->fd<0) FAIL("socket");
+    setnonblock(us->fd);
     setcloexec(us->fd);
 #ifdef CONFIG_IPV6
     if (addr->sa.sa_family==AF_INET6) {
@@ -203,8 +251,7 @@ void udp_make_socket(struct udpcommon *uc, struct udpsock *us)
 	int optval=1;
 	socklen_t optlen=sizeof(optval);
 	r=setsockopt(us->fd,IPPROTO_IPV6,IPV6_V6ONLY,&optval,optlen);
-	if (r) fatal_perror("udp (%s:%d): setsockopt(,IPV6_V6ONLY,&1,)",
-			    cc->loc.file,cc->loc.line);
+	if (r) FAIL("setsockopt(,IPV6_V6ONLY,&1,)");
     }
 #endif
 
@@ -215,13 +262,13 @@ void udp_make_socket(struct udpcommon *uc, struct udpsock *us)
 	/* XXX this fork() and waitpid() business needs to be hidden
 	   in some system-specific library functions. */
 	c=fork();
-	if (c==-1) {
-	    fatal_perror("udp_phase_hook: fork() for authbind");
-	}
+	if (c==-1)
+	    FAIL("fork() for authbind");
 	if (c==0) {
 	    char *argv[5], addrstr[33], portstr[5];
 	    const char *addrfam;
 	    int port;
+	    afterfork();
 	    switch (addr->sa.sa_family) {
 	    case AF_INET:
 		sprintf(addrstr,"%08lX",(long)addr->sin.sin_addr.s_addr);
@@ -254,27 +301,43 @@ void udp_make_socket(struct udpcommon *uc, struct udpsock *us)
 	}
 	while (waitpid(c,&status,0)==-1) {
 	    if (errno==EINTR) continue;
-	    fatal_perror("udp (%s:%d): authbind",cc->loc.file,cc->loc.line);
-	}
-	if (WIFSIGNALED(status)) {
-	    fatal("udp (%s:%d): authbind died on signal %d",cc->loc.file,
-		  cc->loc.line, WTERMSIG(status));
+	    FAIL("waitpid for authbind");
 	}
-	if (WIFEXITED(status) && WEXITSTATUS(status)!=0) {
-	    fatal("udp (%s:%d): authbind died with status %d",cc->loc.file,
-		  cc->loc.line, WEXITSTATUS(status));
+	if (status) {
+	    if (WIFEXITED(status) && WEXITSTATUS(status)<127) {
+		int es=WEXITSTATUS(status);
+		lg_perror(FAIL_LG,es,
+			  "authbind exited with error exit status %d;"
+			  " indicates error",es);
+	    } else {
+		lg_exitstatus(FAIL_LG,status,"authbind");
+	    }
+	    goto failed;
 	}
     } else {
-	if (bind(us->fd, &addr->sa, iaddr_socklen(addr))!=0) {
-	    fatal_perror("udp (%s:%d): bind",cc->loc.file,cc->loc.line);
-	}
+	if (bind(us->fd, &addr->sa, iaddr_socklen(addr))!=0)
+	    FAIL("bind (%s)",iaddr_to_string(addr));
     }
+    return True;
+
+failed:
+    udp_destroy_socket(uc,us);
+    return False;
+
+#undef FAIL
 }
 
 void udp_socks_register(struct udpcommon *uc, struct udpsocks *socks)
 {
     socks->uc=uc;
-    register_for_poll(socks,udp_socks_beforepoll,udp_socks_afterpoll,"udp");
+    socks->interest=
+	register_for_poll(socks,udp_socks_beforepoll,udp_socks_afterpoll,"udp");
+}
+
+void udp_socks_deregister(struct udpcommon *uc, struct udpsocks *socks)
+{
+    socks->uc=uc;
+    deregister_for_poll(socks->interest);
 }
 
 static void udp_phase_hook(void *sst, uint32_t new_phase)
@@ -284,7 +347,7 @@ static void udp_phase_hook(void *sst, uint32_t new_phase)
     struct udpcommon *uc=&st->uc;
     int i;
     for (i=0; i<socks->n_socks; i++)
-	udp_make_socket(uc,&socks->socks[i]);
+	udp_make_socket(uc,&socks->socks[i],M_FATAL);
 
     udp_socks_register(uc,socks);
 }