From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat, 27 Jan 2018 02:46:56 +0000 (+0000)
Subject: fairphone-case: prop: make more variables special and introduce PropProfileAssignment... 
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=reprap-play.git;a=commitdiff_plain;h=9da18fa150ef77340b30da154333ce730ce1ae19

fairphone-case: prop: make more variables special and introduce PropProfileAssignments (nfc)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/fairphone-case.scad b/fairphone-case.scad
index f680de8..fb75586 100644
--- a/fairphone-case.scad
+++ b/fairphone-case.scad
@@ -280,7 +280,7 @@ prlp10 = lpp10 + [1,1] * prl_r10o
 $prpp10 = [0,0];
 $prpp11 = [0, prop_taper_len];
 
-prp_r10 = prl_r10;
+$prp_r10 = prl_r10;
 
 // ---------- modules ----------
 
@@ -624,7 +624,7 @@ module CaseBase(){
 
 function prop_x(gamma) = hp_k / (2 * sin(gamma/2)) - hppT[0];
 
-module PropProfile(gamma, cut=0, rot=0){ ////toplevel
+module PropProfileAssignments(gamma){
   // https://en.wikipedia.org/wiki/Solution_of_triangles#Two_sides_and_the_included_angle_given_(SAS)
   x = prop_x(gamma);
   p = phone_height - prlp10[0] - hppB[0];
@@ -646,56 +646,63 @@ module PropProfile(gamma, cut=0, rot=0){ ////toplevel
 
   $prpp7 = [0, c + (lpp13[1] - $prpp10[1]) ];
 
-  prp_r1 = prc_r1;
-  prp_r11 = prop_main_th/2;
+  $prp_r1 = prc_r1;
+  $prp_r11 = prop_main_th/2;
 
   $prpp1 = $prpp7 + [1,0] *
     // this is approximate, but will do
     (prop_main_th/2 + prop_prop_gap + prcp1[0] - epp4[0]);
   $prpp3 = $prpp1 +
-    v1[0] * -prp_r1 +
+    v1[0] * -$prp_r1 +
     v1[1] * ((prcp2[1] - prcp1[1]) - prop_prop_gap);
   $prpp12 = $prpp3 + v1[0] *
     (prop_end_dia + prop_caserecess_taper * ($prpp1[1] - $prpp3[1]));
-  prp_r8 = prop_main_th;
+  $prp_r8 = prop_main_th;
   $prpp4 = [ prop_main_th/2, $prpp3[1] ];
-  prp_r5 = prp_r8;
-  $prpp5 = [ $prpp12[0] - prp_r5,
-	    $prpp3[1] - prop_prong_h + prp_r5 ];
+  $prp_r5 = $prp_r8;
+  $prpp5 = [ $prpp12[0] - $prp_r5,
+	    $prpp3[1] - prop_prong_h + $prp_r5 ];
   $prpp6 = $prpp4 + [0,-1] * (prop_prong_h +
          prop_prong_heel_slope * ($prpp5[0] - $prpp4[0]));
-  $prpp8 = $prpp4 + [0,-1] * prp_r8;
-  $prpp9 = $prpp8 + [-1,0] * prp_r8;
+  $prpp8 = $prpp4 + [0,-1] * $prp_r8;
+  $prpp9 = $prpp8 + [-1,0] * $prp_r8;
 
-  //#circleat($prpp3,1);
-  //#circleat($prpp12,1);
+  children();
+}
 
-  if (!cut) {
-    hull(){
-      translate($prpp8)
-	intersection(){
-	  circle(prp_r8);
-	  polygon([[-20,-0], [0,0], [20,20]]);
-        }
-      rectfromto($prpp6, $prpp9);
-      translate($prpp5) intersection(){
-	circle(prp_r5);
-	polygon([[-10,-10], [0,0], [10,0]]);
+module PropProfile(gamma, cut=0, rot=0){ ////toplevel
+  PropProfileAssignments(gamma){
+
+    //#circleat($prpp3,1);
+    //#circleat($prpp12,1);
+
+    if (!cut) {
+      hull(){
+	translate($prpp8)
+	  intersection(){
+	    circle($prp_r8);
+	    polygon([[-20,-0], [0,0], [20,20]]);
+	  }
+	rectfromto($prpp6, $prpp9);
+	translate($prpp5) intersection(){
+	  circle($prp_r5);
+	  polygon([[-10,-10], [0,0], [10,0]]);
+	}
+	rectfromto($prpp12 + [0,-0.1], $prpp3);
+      }
+      hull(){
+	circleat($prpp1, $prp_r1);
+	rectfromto($prpp12 + [0,-0.1], $prpp3);
       }
-      rectfromto($prpp12 + [0,-0.1], $prpp3);
-    }
-    hull(){
-      circleat($prpp1, prp_r1);
-      rectfromto($prpp12 + [0,-0.1], $prpp3);
     }
-  }
-  // main shaft
-  rotate([0,0, rot*-$prp_theta]){
-    hull(){
-      extra = cut ? prop_recess_slop : 0;
-      rectfromto($prpp6, $prpp9);
-      circleat($prpp11, prp_r11 + extra);
-      circleat($prpp10, prp_r10 + extra);
+    // main shaft
+    rotate([0,0, rot*-$prp_theta]){
+      hull(){
+	extra = cut ? prop_recess_slop : 0;
+	rectfromto($prpp6, $prpp9);
+	circleat($prpp11, $prp_r11 + extra);
+	circleat($prpp10, $prp_r10 + extra);
+      }
     }
   }
 }