From fbf626c7267dff7a824f2c7af389c94c2535b397 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 24 Apr 2015 19:56:24 +0200 Subject: [PATCH] sysctl: minor simplifications --- src/shared/sysctl-util.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/shared/sysctl-util.c b/src/shared/sysctl-util.c index 650c9c98b..55f4e4860 100644 --- a/src/shared/sysctl-util.c +++ b/src/shared/sysctl-util.c @@ -58,31 +58,23 @@ char *sysctl_normalize(char *s) { } int sysctl_write(const char *property, const char *value) { - _cleanup_free_ char *p = NULL; - char *n; - - log_debug("Setting '%s' to '%s'", property, value); + char *p; - p = new(char, strlen("/proc/sys/") + strlen(property) + 1); - if (!p) - return log_oom(); + assert(property); + assert(value); - n = stpcpy(p, "/proc/sys/"); - strcpy(n, property); + log_debug("Setting '%s' to '%s'", property, value); + p = strjoina("/proc/sys/", property); return write_string_file(p, value); } int sysctl_read(const char *property, char **content) { - _cleanup_free_ char *p = NULL; - char *n; - - p = new(char, strlen("/proc/sys/") + strlen(property) + 1); - if (!p) - return log_oom(); + char *p; - n = stpcpy(p, "/proc/sys/"); - strcpy(n, property); + assert(property); + assert(content); + p = strjoina("/proc/sys/", property); return read_full_file(p, content, NULL); } -- 2.30.2