From ebf4fb3d368732d9f41cb40e3084182c04e731b2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?V=C3=A1clav=20Pavl=C3=ADn?= Date: Wed, 27 Mar 2013 15:16:35 +0100 Subject: [PATCH] core: check return value of rm_rf_dangerous and warn if it fails --- src/core/execute.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index bc876a329..6aa0083bc 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -1559,10 +1559,19 @@ void exec_context_tmp_dirs_done(ExecContext *c) { for(dirp = dirs; *dirp; dirp++) { char *dir; - rm_rf_dangerous(*dirp, false, true, false); + int r; + r = rm_rf_dangerous(*dirp, false, true, false); dir = dirname(*dirp); - rmdir(dir); + if (r < 0) + log_warning("Failed to remove content of temporary directory %s: %s", + dir, strerror(-r)); + else { + r = rmdir(dir); + if (r < 0) + log_warning("Failed to remove temporary directory %s: %s", + dir, strerror(-r)); + } free(*dirp); } -- 2.30.2