From e970a72e94413d9011d510c97eadfdc85c96ccc0 Mon Sep 17 00:00:00 2001 From: Michal Schmidt Date: Sat, 2 Mar 2013 12:44:41 +0100 Subject: [PATCH] manager: turn a superfluous check into assert The crash that the check prevented has been fixed by commit 9e9e2b7. --- src/core/manager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index d976581c9..91d773c2f 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -269,8 +269,9 @@ static void manager_print_jobs_in_progress(Manager *m) { if (j->state == JOB_RUNNING && counter++ == print_nr) break; - if (!j) - return; + /* m->n_running_jobs must be consistent with the contents of m->jobs, + * so the above loop must have succeeded in finding j. */ + assert(counter == print_nr + 1); cylon_pos = m->jobs_in_progress_iteration % 14; if (cylon_pos >= 8) -- 2.30.2