From e2f0672c84ecd7c8a7507d6c1d7ebec1f6348524 Mon Sep 17 00:00:00 2001 From: Daniel Mack Date: Mon, 6 Jul 2015 19:27:20 -0400 Subject: [PATCH] tree-wide: fix write_string_file() user that should not create files The latest consolidation cleanup of write_string_file() revealed some users of that helper which should have used write_string_file_no_create() in the past but didn't. Basically, all existing users that write to files in /sys and /proc should not expect to write to a file which is not yet existant. --- src/shared/smack-util.c | 2 +- src/shared/sysctl-util.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/smack-util.c b/src/shared/smack-util.c index 0c3697b61..047aa294f 100644 --- a/src/shared/smack-util.c +++ b/src/shared/smack-util.c @@ -139,7 +139,7 @@ int mac_smack_apply_pid(pid_t pid, const char *label) { return 0; p = procfs_file_alloca(pid, "attr/current"); - r = write_string_file(p, label, WRITE_STRING_FILE_CREATE); + r = write_string_file(p, label, 0); if (r < 0) return r; #endif diff --git a/src/shared/sysctl-util.c b/src/shared/sysctl-util.c index 232a00505..1de0b94fd 100644 --- a/src/shared/sysctl-util.c +++ b/src/shared/sysctl-util.c @@ -66,7 +66,7 @@ int sysctl_write(const char *property, const char *value) { log_debug("Setting '%s' to '%s'", property, value); p = strjoina("/proc/sys/", property); - return write_string_file(p, value, WRITE_STRING_FILE_CREATE); + return write_string_file(p, value, 0); } int sysctl_read(const char *property, char **content) { -- 2.30.2