From d54110d11d5ea3381cfdd129356b91669b547216 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 18 Jan 2013 00:53:06 +0100 Subject: [PATCH] systemctl: it's probably a good idea not to alter return parameters if we fail We generally follow the rule not to touch return values unless we succeed, so for the sake of uniformity do the same here. --- src/systemctl/systemctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index de1a022ae..cac70673c 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -842,8 +842,9 @@ static int list_dependencies_get_dependencies(DBusConnection *bus, const char *n } finish: if (r < 0) - strv_freep(&ret); - *deps = ret; + strv_free(ret); + else + *deps = ret; return r; } -- 2.30.2