From c26ebdc9e7c5729dd2aa08c0cec8d8b1726afcef Mon Sep 17 00:00:00 2001 From: Ronny Chevalier Date: Fri, 12 Jun 2015 11:37:11 +0200 Subject: [PATCH] login: fix potential null pointer dereference Fix CID 1304686: Dereference after null check (FORWARD_NULL) However, this commit does not fix any bug in logind. It helps to keep the elect_display_compare() function generic. --- src/login/logind-user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/login/logind-user.c b/src/login/logind-user.c index c0b473930..a9cf529e1 100644 --- a/src/login/logind-user.c +++ b/src/login/logind-user.c @@ -763,6 +763,9 @@ static int elect_display_compare(Session *s1, Session *s2) { * is preferred. * * s1 or s2 may be NULL. */ + if (!s1 && !s2) + return 0; + if ((s1 == NULL) != (s2 == NULL)) return (s1 == NULL) - (s2 == NULL); -- 2.30.2