From c08fa87433a5cb3fefefcadb570d03fc6f83dfbb Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 28 Aug 2015 00:13:34 +0200 Subject: [PATCH 1/1] pager: also redirect stderr It's really confusing if stdout goes to the pager, but stderr is written directly to the screen. Hence, make sure both stdout and stderr are passed to the pager when doing autopaging. --- src/shared/pager.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/shared/pager.c b/src/shared/pager.c index d6474030c..1c1cf1605 100644 --- a/src/shared/pager.c +++ b/src/shared/pager.c @@ -129,6 +129,8 @@ int pager_open(bool jump_to_end) { /* Return in the parent */ if (dup2(fd[1], STDOUT_FILENO) < 0) return log_error_errno(errno, "Failed to duplicate pager pipe: %m"); + if (dup2(fd[1], STDERR_FILENO) < 0) + return log_error_errno(errno, "Failed to duplicate pager pipe: %m"); safe_close_pair(fd); return 1; @@ -141,6 +143,11 @@ void pager_close(void) { /* Inform pager that we are done */ fclose(stdout); + stdout = NULL; + + fclose(stderr); + stderr = NULL; + kill(pager_pid, SIGCONT); (void) wait_for_terminate(pager_pid, NULL); pager_pid = 0; -- 2.30.2