From bf175aafd20c9ef974709ef12c5acf836121af33 Mon Sep 17 00:00:00 2001 From: Tom Gundersen Date: Fri, 21 Feb 2014 22:29:25 +0100 Subject: [PATCH] net-util: match on the driver as exposed by ethtool if DRIVER not set Also fix a copy-paste error that broke matching on interface name. --- man/systemd-networkd.service.xml | 5 +++-- man/udev.xml | 4 +++- src/network/networkd-netdev.c | 2 +- src/network/networkd-network.c | 1 + src/shared/net-util.c | 11 ++++++++--- src/shared/net-util.h | 1 + src/udev/net/link-config.c | 1 + 7 files changed, 18 insertions(+), 7 deletions(-) diff --git a/man/systemd-networkd.service.xml b/man/systemd-networkd.service.xml index 026536ebd..2517efc4a 100644 --- a/man/systemd-networkd.service.xml +++ b/man/systemd-networkd.service.xml @@ -216,8 +216,9 @@ The driver currently bound to the device, as exposed by the udev property DRIVER - of its parent device. - + of its parent device, or if that is not set the driver + as exposed by ethtool -i of the + device itself. diff --git a/man/udev.xml b/man/udev.xml index 0e7571588..ae7dc61b0 100644 --- a/man/udev.xml +++ b/man/udev.xml @@ -807,7 +807,9 @@ Driver= The driver currently bound to the device, as exposed by the - udev property DRIVER of its parent device. + udev property DRIVER of its parent device, or if + that is not set the driver as exposed by ethtool -i + of the device itself. diff --git a/src/network/networkd-netdev.c b/src/network/networkd-netdev.c index c3bda6da8..05f21fa87 100644 --- a/src/network/networkd-netdev.c +++ b/src/network/networkd-netdev.c @@ -366,7 +366,7 @@ static int netdev_load_one(Manager *manager, const char *filename) { if (net_match_config(NULL, NULL, NULL, NULL, NULL, netdev->match_host, netdev->match_virt, netdev->match_kernel, netdev->match_arch, - NULL, NULL, NULL, NULL, NULL) <= 0) + NULL, NULL, NULL, NULL, NULL, NULL) <= 0) return 0; r = hashmap_put(netdev->manager->netdevs, netdev->name, netdev); diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c index 2e68bec2e..14fa92aea 100644 --- a/src/network/networkd-network.c +++ b/src/network/networkd-network.c @@ -181,6 +181,7 @@ int network_get(Manager *manager, struct udev_device *device, Network **ret) { udev_device_get_sysattr_value(device, "address"), udev_device_get_property_value(device, "ID_PATH"), udev_device_get_driver(udev_device_get_parent(device)), + udev_device_get_property_value(device, "ID_NET_DRIVER"), udev_device_get_devtype(device), udev_device_get_sysname(device))) { log_debug("%s: found matching network '%s'", diff --git a/src/shared/net-util.c b/src/shared/net-util.c index a8a2c44ba..50cfa2c3f 100644 --- a/src/shared/net-util.c +++ b/src/shared/net-util.c @@ -42,6 +42,7 @@ bool net_match_config(const struct ether_addr *match_mac, Condition *match_arch, const char *dev_mac, const char *dev_path, + const char *dev_parent_driver, const char *dev_driver, const char *dev_type, const char *dev_name) { @@ -64,13 +65,17 @@ bool net_match_config(const struct ether_addr *match_mac, if (match_path && (!dev_path || fnmatch(match_path, dev_path, 0))) return 0; - if (match_driver && !streq_ptr(match_driver, dev_driver)) - return 0; + if (match_driver) { + if (dev_parent_driver && !streq(match_driver, dev_parent_driver)) + return 0; + else if (!streq_ptr(match_driver, dev_driver)) + return 0; + } if (match_type && !streq_ptr(match_type, dev_type)) return 0; - if (match_name && (!dev_path || fnmatch(match_name, dev_name, 0))) + if (match_name && (!dev_name || fnmatch(match_name, dev_name, 0))) return 0; return 1; diff --git a/src/shared/net-util.h b/src/shared/net-util.h index 908fb22ff..99479e1f5 100644 --- a/src/shared/net-util.h +++ b/src/shared/net-util.h @@ -38,6 +38,7 @@ bool net_match_config(const struct ether_addr *match_mac, Condition *match_arch, const char *dev_mac, const char *dev_path, + const char *dev_parent_driver, const char *dev_driver, const char *dev_type, const char *dev_name); diff --git a/src/udev/net/link-config.c b/src/udev/net/link-config.c index 40b1d7f7b..92d248fc6 100644 --- a/src/udev/net/link-config.c +++ b/src/udev/net/link-config.c @@ -247,6 +247,7 @@ int link_config_get(link_config_ctx *ctx, struct udev_device *device, link_confi udev_device_get_sysattr_value(device, "address"), udev_device_get_property_value(device, "ID_PATH"), udev_device_get_driver(udev_device_get_parent(device)), + udev_device_get_property_value(device, "ID_NET_DRIVER"), udev_device_get_devtype(device), NULL)) { log_debug("Config file %s applies to device %s", -- 2.30.2