From bd390ae7c75dc5bb0e151e6fd2f7156998ed710f Mon Sep 17 00:00:00 2001 From: Elia Pinto Date: Wed, 22 Jan 2014 03:28:43 -0800 Subject: [PATCH] build-sys: add a phony target for cppcheck The cppcheck target was introduced by commit 16f4efb4150c65e3c61adaa8ea512489de49f532 "build-sys: add cppcheck target". But it is preferable to use a make phony target for it, as this patch does. There are two general reasons to use a phony target: to avoid a conflict with a file of the same name, and to improve performance. In this case the first reason is obvious, and the second is that make skips the implicit rule search for phony targets, since it knows that phony targets do not name actual files that could be remade from other files (as described in the "Gnu Make" Manual). --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 37073d23a..0b891a771 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5008,6 +5008,7 @@ tests += \ test-libsystemd-id128-sym endif +.PHONY: cppcheck cppcheck: cppcheck --enable=all -q $(top_srcdir) -- 2.30.2